Page MenuHomeFreeBSD

arm64: Add arm64 SVE tests
AcceptedPublic

Authored by andrew on Jan 4 2024, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 31, 9:55 AM
Unknown Object (File)
Sat, Mar 28, 12:45 PM
Unknown Object (File)
Thu, Mar 26, 5:15 AM
Unknown Object (File)
Thu, Mar 19, 7:54 PM
Unknown Object (File)
Mon, Mar 9, 11:10 AM
Unknown Object (File)
Mon, Mar 9, 11:10 AM
Unknown Object (File)
Feb 24 2026, 3:21 PM
Unknown Object (File)
Feb 6 2026, 8:32 PM
Subscribers

Details

Reviewers
kib
markj
Group Reviewers
arm64
Summary

Add the tests/sys/arch directory for architecture-specific tests and
use it to add arm64 SVE tests. These test the kernel is managing the
SVE state in a way we expect.

These tests require SVE hardware support to run so will skip when they
can't detect it.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71899
Build 68782: arc lint + arc unit

Event Timeline

So would you also need a getcontext/setcontext test with SVE state changing in between test too?

Needs an update to the appropriate mtree file

  • Add an mtree entry
  • Check the headder type
  • Use a brk instruction to stop execution as a syscall may drop the SVE context
tests/sys/Makefile
7

Can we use the same layout as the kernel sources? i.e., no arch/ and aarch64->arm64. All else being equal, having the same layout makes tests a bit easier to find.

tests/sys/arch/Makefile
2

Extra newline.

tests/sys/Makefile
7

I put them in arch so we don't need to list all the architectures in the mtree file

tests/sys/Makefile
7

I don't follow. The mtree update in this patch is incomplete, it's missing the aarch64 entry under arch. You have to list them either way, as, e.g., BSD.usr.dist does for user man pages. But this patch only needs to add an arm64 entry.

tests/sys/Makefile
7

The tests are installed into /usr/tests/sys/arch

Remove extra lines at the start of Makefiles

This revision is now accepted and ready to land.Fri, Apr 3, 8:49 AM