stand: collapse all copies of *copyenv into md_copyenv
ClosedPublic
Actions

Authored by imp on Sep 14 2022, 7:39 PM.

Details

Reviewers

manu
tsoome
kevans

Group Reviewers

bhyve

Commits

rG84a31012bf09: stand: collapse all copies of *copyenv into md_copyenv
rGfc352701ff3a: stand: collapse all copies of *copyenv into md_copyenv

Summary

Use the efi's bi_copyenv to md_copyenv and place it in modinfo.c. Remove
all other nearly identical and efi's has the best error handling.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47390
Build 44277: arc lint + arc unit

Event Timeline

imp created this revision.Sep 14 2022, 7:39 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 14 2022, 7:39 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

imp requested review of this revision.Sep 14 2022, 7:39 PM

Harbormaster completed remote builds in B47390: Diff 110566.Sep 14 2022, 7:39 PM

imp added reviewers: tsoome, kevans.Sep 14 2022, 7:40 PM

imp added a parent revision: D36573: stand: Move MOD_xxx macros from modinfo.h to .c.

imp added a child revision: D36575: stand: Allocate bootinfo rather than have it be static.Sep 14 2022, 7:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2022, 3:54 PM

Closed by commit rGfc352701ff3a: stand: collapse all copies of *copyenv into md_copyenv (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGfc352701ff3a: stand: collapse all copies of *copyenv into md_copyenv.

imp added a commit: rG84a31012bf09: stand: collapse all copies of *copyenv into md_copyenv.Jan 24 2023, 10:18 PM

Revision Contents
Changeset List

Path

Size

stand/

common/

metadata.c

28 lines

modinfo.h

1 line

modinfo.c

39 lines

efi/

loader/

bootinfo.c

41 lines

i386/

libi386/

28 lines

2 lines

2 lines

1 line

userboot/

28 lines

2 lines

2 lines

1 line

Diff 110566

View Options

stand/common/metadata.c

View Options

stand/common/modinfo.h

View Options

stand/common/modinfo.c

View Options

stand/efi/loader/bootinfo.c

View Options

stand/i386/libi386/bootinfo.c

View Options

stand/i386/libi386/bootinfo32.c

View Options

stand/i386/libi386/bootinfo64.c

View Options

stand/i386/libi386/libi386.h

View Options

stand/userboot/userboot/bootinfo.c

View Options

stand/userboot/userboot/bootinfo32.c

View Options

stand/userboot/userboot/bootinfo64.c

View Options

stand/userboot/userboot/libuserboot.h

stand: collapse all copies of *copyenv into md_copyenvClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 110566

stand/common/metadata.c

stand/common/modinfo.h

stand/common/modinfo.c

stand/efi/loader/bootinfo.c

stand/i386/libi386/bootinfo.c

stand/i386/libi386/bootinfo32.c

stand/i386/libi386/bootinfo64.c

stand/i386/libi386/libi386.h

stand/userboot/userboot/bootinfo.c

stand/userboot/userboot/bootinfo32.c

stand/userboot/userboot/bootinfo64.c

stand/userboot/userboot/libuserboot.h

stand: collapse all copies of *copyenv into md_copyenv
ClosedPublic
Actions

Revision Contents
Changeset List