Differential D36575

stand: Allocate bootinfo rather than have it be static
ClosedPublic
Actions

Authored by imp on Sep 14 2022, 7:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 9, 8:26 PM

	Unknown Object (File)
	Fri, Oct 31, 12:10 AM

	Unknown Object (File)
	Sat, Oct 25, 11:58 PM

	Unknown Object (File)
	Sat, Oct 25, 2:31 AM

	Unknown Object (File)
	Sat, Oct 25, 2:25 AM

	Unknown Object (File)
	Wed, Oct 22, 3:14 AM

	Unknown Object (File)
	Oct 16 2025, 5:49 PM

	Unknown Object (File)
	Oct 16 2025, 1:52 AM

Subscribers

Details

Reviewers

manu
tsoome
kevans

Commits

rGf7f2e8226c52: stand: Allocate bootinfo rather than have it be static
rG9758dd3de1cd: stand: Allocate bootinfo rather than have it be static

Summary

This saves 80 bytes (the new bootinfo structure was 84 bytes, and a
pointer is 4 bytes). The bi_load32 code is the same size.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sep 14 2022, 7:48 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 14 2022, 7:48 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Sep 14 2022, 7:48 PM

Harbormaster completed remote builds in B47391: Diff 110567.Sep 14 2022, 7:48 PM

imp added a parent revision: D36574: stand: collapse all copies of *copyenv into md_copyenv.Sep 14 2022, 7:49 PM

imp added reviewers: tsoome, kevans.

imp added a child revision: D36576: stand/geli: Allocate saved_keys instead of making it static.Sep 14 2022, 7:53 PM

tsoome accepted this revision.Sep 14 2022, 8:32 PM

This revision is now accepted and ready to land.Sep 14 2022, 8:32 PM

Closed by commit rG9758dd3de1cd: stand: Allocate bootinfo rather than have it be static (authored by imp). · Explain WhySep 16 2022, 3:54 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG9758dd3de1cd: stand: Allocate bootinfo rather than have it be static.

imp added a commit: rGf7f2e8226c52: stand: Allocate bootinfo rather than have it be static.Jan 24 2023, 10:18 PM

Revision Contents
Changeset List

Path

Size

stand/

i386/

libi386/

29 lines

Diff 110650

stand/i386/libi386/bootinfo32.c

Loading...