stand/geli: Allocate saved_keys instead of making it static
AcceptedPublic
Actions

Authored by imp on Sep 14 2022, 7:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 20, 2:39 AM

	Unknown Object (File)
	Sat, Jun 20, 12:31 AM

	Unknown Object (File)
	Thu, Jun 18, 11:22 PM

	Unknown Object (File)
	Tue, Jun 16, 4:33 AM

	Unknown Object (File)
	May 16 2026, 4:44 PM

	Unknown Object (File)
	May 16 2026, 4:44 PM

	Unknown Object (File)
	Apr 27 2026, 7:03 PM

	Unknown Object (File)
	Apr 27 2026, 7:00 PM

View All Files

Subscribers

dab

Details

Reviewers

manu
kevans
tsoome

Summary

The saved_keys buffer is 4k and was allocated in bss. Dynamically
allocate it at runtime. This saves 4k of space in the lower 640k.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47392
Build 44279: arc lint + arc unit

Event Timeline

imp created this revision.Sep 14 2022, 7:50 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 14 2022, 7:50 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Sep 14 2022, 7:50 PM

Harbormaster completed remote builds in B47392: Diff 110568.Sep 14 2022, 7:50 PM

imp added a child revision: D36577: stand/elf: Only support swapping headers on powerpc..Sep 14 2022, 7:53 PM

imp added reviewers: kevans, tsoome.

imp added a parent revision: D36575: stand: Allocate bootinfo rather than have it be static.

tsoome accepted this revision.Sep 14 2022, 8:29 PM

This revision is now accepted and ready to land.Sep 14 2022, 8:29 PM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

geli/

geliboot.c

12 lines

Diff 110568

View Options

stand/libsa/geli/geliboot.c

stand/geli: Allocate saved_keys instead of making it staticAcceptedPublicActions