Page MenuHomeFreeBSD
Differential D36320

mbuf: Don't support PAGE_SIZE < 4K
ClosedPublic
Actions

Authored by brooks on Aug 23 2022, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 28, 5:20 PM
Unknown Object (File)
Wed, Aug 26, 4:09 AM
Unknown Object (File)
Wed, Aug 26, 4:07 AM
Unknown Object (File)
Sun, Aug 23, 9:48 AM
Unknown Object (File)
Sat, Aug 22, 7:32 AM
Unknown Object (File)
Sat, Aug 15, 11:27 AM
Unknown Object (File)
Mon, Aug 10, 11:09 AM
Unknown Object (File)
Mon, Aug 10, 9:38 AM
View All Files
Subscribers
glebius
imp

Details

Reviewers
jhb
markj
imp
kp
Commits
rG840327e5ddf3: mbuf: Don't support PAGE_SIZE < 4K
Summary

The Vax supported such things, but FreeBSD does not. This further
implies that MJUMPAGESIZE > MCLBYTES so assert this and remove code
handling them being equal.

Sponsored by: DARPA, AFRL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47090
Build 43977: arc lint + arc unit

Event Timeline

brooks created this revision.Aug 23 2022, 9:15 PM
Herald added subscribers: glebius, imp. · View Herald TranscriptAug 23 2022, 9:15 PM
brooks requested review of this revision.Aug 23 2022, 9:15 PM
brooks added a parent revision: D36319: m_get3: add an MLINK for the manpage.
brooks added reviewers: imp, kp.Aug 23 2022, 9:15 PM
Harbormaster completed remote builds in B47090: Diff 109742.Aug 23 2022, 9:16 PM
brooks added a child revision: D36321: cxgbe: don't support MJUMPAGESIZE != MCLBYTES.Aug 23 2022, 9:16 PM
jhb accepted this revision.Aug 23 2022, 10:01 PM
jhb added inline comments.
sys/kern/kern_mbuf.c
67
This revision is now accepted and ready to land.Aug 23 2022, 10:01 PM
brooks updated this revision to Diff 109750.Aug 23 2022, 10:12 PM
  • Assert wording tweak from jhb
This revision now requires review to proceed.Aug 23 2022, 10:12 PM
Harbormaster completed remote builds in B47097: Diff 109750.Aug 23 2022, 10:12 PM
brooks marked an inline comment as done.Aug 23 2022, 10:12 PM
imp accepted this revision.Aug 23 2022, 10:52 PM

tl;dr: 4k pages are the smallest among traditional BSD hardware (except VAX, which used a 4k logical page size).

This revision is now accepted and ready to land.Aug 23 2022, 10:52 PM
kp accepted this revision.Aug 24 2022, 12:15 PM
Closed by commit rG840327e5ddf3: mbuf: Don't support PAGE_SIZE < 4K (authored by brooks). · Explain WhyAug 24 2022, 5:36 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG840327e5ddf3: mbuf: Don't support PAGE_SIZE < 4K.

Revision Contents
Changeset List

PathSize
sys/
kern/
3 lines
sys/
6 lines
4 lines

Diff 109742

View Options

sys/kern/kern_mbuf.c

Loading...
View Options

sys/sys/mbuf.h

Loading...
View Options

sys/sys/param.h

Loading...