Differential D36321

cxgbe: don't support MJUMPAGESIZE != MCLBYTES
ClosedPublic
Actions

Authored by brooks on Aug 23 2022, 9:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 10, 1:11 AM

	Unknown Object (File)
	Tue, Apr 9, 11:54 PM

	Unknown Object (File)
	Mar 22 2024, 10:08 PM

	Unknown Object (File)
	Mar 22 2024, 10:08 PM

	Unknown Object (File)
	Mar 22 2024, 10:08 PM

	Unknown Object (File)
	Mar 22 2024, 9:55 PM

	Unknown Object (File)
	Dec 12 2023, 3:05 PM

	Unknown Object (File)
	Nov 30 2023, 4:11 PM

View All 38 Files

Subscribers

Details

Reviewers

jhb
markj
np
imp

Commits

rG9c3ad5ba932b: cxgbe: don't support MJUMPAGESIZE != MCLBYTES

Summary

This could only happen on systems with PAGE_SIZE < 4K and FreeBSD
doesn't support such systems.

Sponsored by: DARPA, AFRL

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Aug 23 2022, 9:16 PM

Herald added subscribers: ae, imp. · View Herald TranscriptAug 23 2022, 9:16 PM

brooks requested review of this revision.Aug 23 2022, 9:16 PM

Harbormaster completed remote builds in B47091: Diff 109743.Aug 23 2022, 9:16 PM

brooks added a parent revision: D36320: mbuf: Don't support PAGE_SIZE < 4K.Aug 23 2022, 9:16 PM

brooks added a reviewer: np.Aug 23 2022, 9:16 PM

brooks added a child revision: D36322: freebsd32_sendmsg: fix control message ABI.Aug 23 2022, 9:16 PM

jhb accepted this revision.Aug 23 2022, 10:01 PM

This revision is now accepted and ready to land.Aug 23 2022, 10:01 PM

Some history: Only the VAX ever had a page size smaller than 4k. It had a 512 byte page. Even 4BSD combined these into 1k or 2k logical page sizes that the system. NetBSD uses 4k logical pages these days.
68k, 88k, pc532, mips, powerpc, sparc, alpha, x86, arm, aarch64, pa-risc, and others designer ones that Linux supports that I surveyed have 4k or larger pages.

So there's very few systems with this page size among the traditional targets of BSD, let alone the rather limited subset that FreeBSD works on today, or is even remotely expected to work on in the future.

np accepted this revision.Aug 24 2022, 12:37 AM

Closed by commit rG9c3ad5ba932b: cxgbe: don't support MJUMPAGESIZE != MCLBYTES (authored by brooks). · Explain WhyAug 24 2022, 5:37 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG9c3ad5ba932b: cxgbe: don't support MJUMPAGESIZE != MCLBYTES.

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

4 lines

8 lines

Diff 109773

sys/dev/cxgbe/adapter.h

Loading...

sys/dev/cxgbe/t4_sge.c

Loading...