Differential D34797
Remove checks for __GNUCLIKE_ASM assuming it is always true. Authored by jhb on Apr 6 2022, 2:25 PM. Tags None Referenced Files
Subscribers
Details All supported compilers (modern versions of GCC and clang) support Many places didn't have an #else so would just silently do the wrong
Diff Detail
Event TimelineComment Actions I have a cdefs cleanup branch somewhere with something very similar in it. I'll rebase and cope. I ran into some issues with it, but don't recall why work stalled on it exactly other than non-standard compilers and ports needing older gcc versions to build... Intel's compiler has moved to gnu asm a long time ago and we've been deorbiting support for the ancient version. Comment Actions Just so it's documented here and not just on IRC: My general goal with this set of changes is to assume modern versions of GCC/clang (or a compiler that can understand modern GNU C) to build FreeBSD itself. To that end, this series doesn't change anything in <sys/cdefs.h> itself so that more esoteric compilers should in theory still be able to build applications like hello world even after these changes. It is true that some of these headers are also (ab)used in userspace, especially <machine/atomic.h> (and perhaps <machine/ieeefp.h> is the most likely candidate). However, in most cases while we might allow software to compile by providing prototypes in place of inlines, the software won't actually work as we don't ship the functions the prototypes want to link against, so I don't think we will break anything that isn't already broken. An exp-run of this series probably does make sense. Comment Actions Exprun PR for the whole series: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263102 Comment Actions FWIW, the system literally won't compiled without __GNUCLIKE_ASM defined due to pcpu.h
| ||||||||||||||||||||||||||||||||||||||||||||