ClosedPublic
Actions

Authored by jhb on Apr 6 2022, 2:25 PM.

Details

Reviewers

brooks
emaste
imp

Commits

rG2cb2e6691fae: ce,cp: Remove pointless checks for <sys/cdefs.h>
rG17554af4e853: ce,cp: Remove pointless checks for <sys/cdefs.h>

Summary

Both of these headers check for _SYS_CDEFS_H_ after including
<sys/param.h> which itself includes <sys/cdefs.h>.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 6 2022, 2:25 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2022, 2:25 PM

jhb requested review of this revision.Apr 6 2022, 2:25 PM

Harbormaster completed remote builds in B45020: Diff 104661.Apr 6 2022, 2:25 PM

jhb added a child revision: D34796: x86: Remove silly checks for <sys/cdefs.h>..Apr 6 2022, 2:25 PM

leaving aside question of 'why do we still need these drivers', these change are good.

This revision is now accepted and ready to land.Apr 6 2022, 2:27 PM

In D34795#788641, @imp wrote:

leaving aside question of 'why do we still need these drivers', these change are good.

Perhaps we'll sort that out in D23928, eventually. They might get removed with a final spl* cleanup.

brooks accepted this revision.Apr 8 2022, 9:13 PM

Closed by commit rG17554af4e853: ce,cp: Remove pointless checks for <sys/cdefs.h> (authored by jhb). · Explain WhyApr 12 2022, 5:11 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG17554af4e853: ce,cp: Remove pointless checks for <sys/cdefs.h>.

jhb added a commit: rG2cb2e6691fae: ce,cp: Remove pointless checks for <sys/cdefs.h>.May 13 2022, 10:55 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ce/

machdep.h

4 lines

cp/

machdep.h

4 lines

Diff 104913

View Options

sys/dev/ce/machdep.h