.
ClosedPublic
Actions

Authored by jhb on Apr 6 2022, 2:25 PM.

Details

Reviewers

brooks
emaste
imp

Commits

rG848513a77f27: x86: Remove silly checks for <sys/cdefs.h>.
rG1c1bf5bd7c1e: x86: Remove silly checks for <sys/cdefs.h>.

Summary

These headers #include <sys/cdefs.h> right after checking if it has
already been #included. The nested #include already existed when the
check for _SYS_CDEFS_H_ was added, so the check shouldn't have been
added in the first place.

Reported by: brooks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 6 2022, 2:25 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2022, 2:25 PM

jhb requested review of this revision.Apr 6 2022, 2:25 PM

Harbormaster completed remote builds in B45021: Diff 104662.Apr 6 2022, 2:25 PM

jhb added a parent revision: D34795: ce,cp: Remove pointless checks for <sys/cdefs.h>.Apr 6 2022, 2:25 PM

jhb added a child revision: D34797: Remove checks for __GNUCLIKE_ASM assuming it is always true..

imp accepted this revision.Apr 6 2022, 2:27 PM

This revision is now accepted and ready to land.Apr 6 2022, 2:27 PM

emaste accepted this revision.Apr 6 2022, 3:04 PM

FYI, I've got a separate diff to remove the sys/cdefs.h include entirely since it's pointless.

Closed by commit rG1c1bf5bd7c1e: x86: Remove silly checks for <sys/cdefs.h>. (authored by jhb). · Explain WhyApr 12 2022, 5:12 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1c1bf5bd7c1e: x86: Remove silly checks for <sys/cdefs.h>..

jhb added a commit: rG848513a77f27: x86: Remove silly checks for <sys/cdefs.h>..May 13 2022, 10:56 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

in_cksum.h

4 lines

i386/

include/

in_cksum.h

4 lines

Diff 104914

View Options

sys/amd64/include/in_cksum.h