suppress set but not used warnings for kernel builds
ClosedPublic
Actions

Authored by rew on Apr 4 2022, 11:46 PM.

Details

Reviewers

imp
mjg

Commits

rGe8e691983bb7: suppress set but not used warnings for kernel builds

Summary

Turn off set but not used warnings for kernel builds with clang13.

These warnings can be turned back on by setting the following in src.conf:

WITH_SET_BUT_NOTUSED_KERNEL_WARNINGS=

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45005
Build 41893: arc lint + arc unit

Event Timeline

rew created this revision.Apr 4 2022, 11:46 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 4 2022, 11:46 PM

rew requested review of this revision.Apr 4 2022, 11:46 PM

Harbormaster completed remote builds in B45002: Diff 104593.Apr 4 2022, 11:46 PM

this breaks boostrapping

sys/conf/kmod.mk
119	use ${NO_WUNUSED_BUT_SET_VARIABLE} instead.

This revision now requires changes to proceed.Apr 5 2022, 12:07 AM

feedback from imp: use ${NO_WUNUSED_BUT_SET_VARIABLE}

Harbormaster completed remote builds in B45005: Diff 104597.Apr 5 2022, 1:13 AM

I have ~65 changes in my queue to eliminate all the trivial errors for the arm kernel build.
I plan on pushing them shortly, and there may be some overlap with your work, but I've finished universe with them...

This revision is now accepted and ready to land.Apr 5 2022, 2:51 AM

Modules get built even if particular code is built-in into the kernel, artificially raising the clang spam.

The fix would be to stop building said modules to begin with.

Taking this review in a different direction..

Build kernel with -Wno-unused-but-set-variable by default.

This revision now requires review to proceed.Apr 5 2022, 6:41 PM

Harbormaster completed remote builds in B45009: Diff 104633.Apr 5 2022, 6:41 PM

rew retitled this revision from suppress set but not used warnings for kernel modules to suppress set but not used warnings for kernel builds.Apr 5 2022, 6:49 PM

rew edited the summary of this revision. (Show Details)

mjg accepted this revision.Apr 5 2022, 7:04 PM

This revision is now accepted and ready to land.Apr 5 2022, 7:04 PM

imp accepted this revision.Apr 5 2022, 8:35 PM

imp added inline comments.