Page MenuHomeFreeBSD
Differential D33562

LinuxKPI: Constantly use _LINUXKPI_ prefix in include guards
ClosedPublic
Actions

Authored by wulf on Dec 19 2021, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 8:26 PM
Unknown Object (File)
Tue, Sep 8, 3:17 PM
Unknown Object (File)
Mon, Sep 7, 12:34 AM
Unknown Object (File)
Sun, Sep 6, 1:56 AM
Unknown Object (File)
Sat, Sep 5, 2:14 PM
Unknown Object (File)
Sat, Sep 5, 1:26 PM
Unknown Object (File)
Thu, Sep 3, 5:05 PM
Unknown Object (File)
Thu, Sep 3, 12:19 PM
View All Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
bz
• hselasky
manu
emaste
Commits
rG2d0694b95350: LinuxKPI: Constantly use _LINUXKPI_ prefix in include guards
rG307f78f3ed90: LinuxKPI: Constantly use _LINUXKPI_ prefix in include guards
Summary

As per request by bz@

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf created this revision.Dec 19 2021, 11:25 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptDec 19 2021, 11:25 AM
wulf requested review of this revision.Dec 19 2021, 11:25 AM
Harbormaster completed remote builds in B43472: Diff 100285.Dec 19 2021, 11:25 AM
wulf edited the summary of this revision. (Show Details)Dec 19 2021, 11:27 AM
• hselasky accepted this revision.Dec 19 2021, 11:31 AM

Looks good.

This revision is now accepted and ready to land.Dec 19 2021, 11:31 AM
manu accepted this revision.Dec 21 2021, 8:55 AM
bz accepted this revision.Dec 21 2021, 3:00 PM

Thank you! Feel free to get it in an MFC it timely if possible to avoid too many conflicts.

emaste accepted this revision.Dec 21 2021, 5:53 PM
emaste added inline comments.
sys/compat/linuxkpi/common/include/linux/acpi.h
31–33

Does the _LINUX_ bit match the Linux version? _LINUXKPI_LINUX_ seems a bit strange unless it's following Linux convention

manu added inline comments.Dec 21 2021, 6:02 PM
sys/compat/linuxkpi/common/include/linux/acpi.h
31–33

We've put the path in most (all ?) files so as this is linux/acpi.h this become LINUX_ACPI_H_

Closed by commit rG307f78f3ed90: LinuxKPI: Constantly use _LINUXKPI_ prefix in include guards (authored by wulf). · Explain WhyJan 10 2022, 7:52 PM
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rG307f78f3ed90: LinuxKPI: Constantly use _LINUXKPI_ prefix in include guards.
wulf added a commit: rG2d0694b95350: LinuxKPI: Constantly use _LINUXKPI_ prefix in include guards.Jan 22 2022, 7:40 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
acpi/
6 lines
6 lines
6 lines
asm/
6 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
fpu/
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
linux/
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
6 lines
4 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
4 lines
6 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
4 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
net/
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines

Diff 101238

View Options

sys/compat/linuxkpi/common/include/acpi/acpi.h

Loading...
View Options

sys/compat/linuxkpi/common/include/acpi/acpi_bus.h

Loading...
View Options

sys/compat/linuxkpi/common/include/acpi/video.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/atomic-long.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/atomic.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/atomic64.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/barrier.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/byteorder.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/cpufeature.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/fcntl.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/fpu/api.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/io.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/msr.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/pgtable.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/smp.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/types.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/uaccess.h

Loading...
View Options

sys/compat/linuxkpi/common/include/asm/unaligned.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/acpi.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/anon_inodes.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/atomic.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/average.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/backlight.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/bitfield.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/bitmap.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/bitops.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/bottom_half.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/bsearch.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/cache.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/capability.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/cdev.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/clocksource.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/compat.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/compiler.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/completion.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/cpu.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/crc32.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/dcache.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/debugfs.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/delay.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/devcoredump.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/device.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/dma-attrs.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/dma-mapping.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/dmapool.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/dmi.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/efi.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/err.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/errno.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/etherdevice.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/export.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/file.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/fs.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/gcd.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/gfp.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/hardirq.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/highmem.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/hrtimer.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/idr.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/if_arp.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/if_ether.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/if_vlan.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/in.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/in6.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/inetdevice.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/interrupt.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/interval_tree.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/io-mapping.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/io.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/ioctl.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/iopoll.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/ip.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/irq_work.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/irqreturn.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/jhash.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/jiffies.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/jump_label.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/kdev_t.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/kmod.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/kobject.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/kref.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/kthread.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/ktime.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/list.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/llist.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/lockdep.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/log2.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/math64.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/miscdevice.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/mm.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/mm_types.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/mod_devicetable.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/module.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/moduleparam.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/mutex.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/net.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/net_dim.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/netdev_features.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/notifier.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/numa.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/overflow.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/page.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/pagemap.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/pfn.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/pfn_t.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/pid.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/poison.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/poll.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/power_supply.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/preempt.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/prefetch.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/printk.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/radix-tree.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/random.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/ratelimit.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/rbtree.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/rculist.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/rcupdate.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/refcount.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/rwlock.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/rwsem.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/scatterlist.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/sched.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/semaphore.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/seq_file.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/seqlock.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/shmem_fs.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/shrinker.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/sizes.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/slab.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/smp.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/socket.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/spinlock.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/srcu.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/string.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/stringify.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/swap.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/sysfs.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/tcp.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/time.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/timer.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/types.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/uaccess.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/udp.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/uuid.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/vmalloc.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/wait.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/wait_bit.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/workqueue.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/ww_mutex.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/xarray.h

Loading...
View Options

sys/compat/linuxkpi/common/include/net/addrconf.h

Loading...
View Options

sys/compat/linuxkpi/common/include/net/ieee80211_radiotap.h

Loading...
View Options

sys/compat/linuxkpi/common/include/net/if_inet6.h

Loading...
View Options

sys/compat/linuxkpi/common/include/net/ip.h

Loading...
View Options

sys/compat/linuxkpi/common/include/net/ipv6.h

Loading...
View Options

sys/compat/linuxkpi/common/include/net/netevent.h

Loading...
View Options

sys/compat/linuxkpi/common/include/net/tcp.h

Loading...