Page MenuHomeFreeBSD

pkgbase: only create dirs for `/usr/tests/cddl`-homed tests as needed
Needs ReviewPublic

Authored by ngie on Tue, Oct 20, 9:17 PM.

Details

Reviewers
gnn
ivy
Summary

Before this change, directories needed when MK_DTRACE_TESTS != no and
MK_ZFS_TESTS != no but not MK_TESTS != no, were being created via
BSD.tests.dist as part of the standard build/install process with the
top-level hierarchy target. This behavior resulted in make check-old
flagging a lot of issues after 30c20ca26e105c, even after `make
delete-old` was run and the directories were removed.

Moving the paths off to their own separate pkgbase dists and mtree files
ensures that the paths are no longer needlessly created when `make
hierarchy` was run and MK_TESTS != no post-30c20ca26e105c.

Net change: MK_DTRACE_TESTS and MK_ZFS_TESTS are now included in the
dtrace-tests and zfs-tests distributions instead of the tests
distribution.

Relnotes: yes
PR: 299650
MFC after: 1 week
Reported by: des

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78449
Build 75332: arc lint + arc unit

Event Timeline

ngie requested review of this revision.Tue, Oct 20, 9:17 PM
ngie retitled this revision from pkgbase: only create directories with mtree when their knobs are enabled to pkgbase: only create directories with mtree for test suites when requested.Tue, Oct 20, 9:18 PM
ngie added inline comments.
Makefile.inc1
1529–1567

I'll DRY this logic later, like @imp did with src.opts.mk, et al.

ngie retitled this revision from pkgbase: only create directories with mtree for test suites when requested to pkgbase: only create dir for `/usr/tests/cddl`-homed test suites if needed.Tue, Oct 20, 9:40 PM
ngie retitled this revision from pkgbase: only create dir for `/usr/tests/cddl`-homed test suites if needed to pkgbase: only create dirs for `/usr/tests/cddl`-homed tests as needed.Tue, Oct 20, 9:56 PM

Expand scope to include a subset of MK_CDDL-gated tests (in general)

More directories will need to be added later -- this is just a start.

Add build machinery/metadata under packages/...