bhyve: Add an option to prevent automatic restart in monitor mode
Needs ReviewPublic
Actions

Authored by bnovkov on Sun, Aug 23, 1:04 PM.

Details

Reviewers

andrew

Group Reviewers

bhyve

Summary

Monitor mode will currently unconditionally restart the guest if it
reboots, which can be incovenient in certain situations (e.g., resetting
the guest after a panic).

Address this by introducing a way to prevent automatic guest restarts
in monitor mode.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75980
Build 72863: arc lint + arc unit

Event Timeline

bnovkov created this revision.Sun, Aug 23, 1:04 PM

Herald added a reviewer: andrew. · View Herald TranscriptSun, Aug 23, 1:04 PM

Herald added subscribers: ziaee, bcran, rgrimes and 2 others. · View Herald Transcript

bnovkov requested review of this revision.Sun, Aug 23, 1:04 PM

Harbormaster completed remote builds in B75980: Diff 184783.Sun, Aug 23, 1:04 PM

Thank you!

usr.sbin/bhyve/amd64/bhyverun_machdep.c
207	This is a backward compat break, shouldn't we handle the old name with bhyve_cfg_warn()?
usr.sbin/bhyve/bhyve.8
349	You might clarify that this option has no effect unless `-M` is specified or monitor.enabled is configured. I think the SIGNAL HANDLING section should also explain how signal handling interacts with monitor mode and the new no_reboot option.
usr.sbin/bhyve/bhyve_config.5
239	You changed this to `monitor.enabled`.