Paths

Table of Contentst

Differential D54332

bhyve(8): Fix consistency and terms in manpage
ClosedPublic
Actions

Authored by michaelo on Sun, Dec 21, 4:46 PM.

Tags

None

Referenced Files

	F140564195: D54332.diff
	Thu, Dec 25, 8:11 AM

	F140525324: D54332.id168516.diff
	Wed, Dec 24, 10:01 PM

	Unknown Object (File)
	Wed, Dec 24, 4:41 PM

	Unknown Object (File)
	Mon, Dec 22, 3:56 PM

	Unknown Object (File)
	Mon, Dec 22, 6:52 AM

	Unknown Object (File)
	Mon, Dec 22, 4:18 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG5819f8b285fc: bhyve.8: Fix consistency and terms in manpage

Summary

Correct inconsistent spelling of terms and duplication.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michaelo created this revision.Sun, Dec 21, 4:46 PM

Herald added a reviewer: bhyve. · View Herald TranscriptSun, Dec 21, 4:46 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

michaelo requested review of this revision.Sun, Dec 21, 4:46 PM

Harbormaster completed remote builds in B69426: Diff 168495.Sun, Dec 21, 4:46 PM

markj added a subscriber: markj.Mon, Dec 22, 12:39 AM

markj added inline comments.

usr.sbin/bhyve/bhyve.8
709–710
1047–1049	Can we fix these sentences while here? A value of 1 indicates that the device is a solid state disk, i.e., non-rotational. The default value is 0.

ziaee added inline comments.Mon, Dec 22, 12:57 AM

usr.sbin/bhyve/bhyve.8
171	For true consistency we actually need to standardize it the other way, the interface has been externally called fw_cfg since even before we got it, right? https://www.qemu.org/docs/master/specs/fw_cfg.html

Incorporate reviews

Harbormaster completed remote builds in B69437: Diff 168516.Mon, Dec 22, 10:05 AM

Thanks michaelo!

usr.sbin/bhyve/bhyve.8
712	In the roff language, new sentences start on newlines. You can check the linter with `mandoc -Tlint /here/is/the/manual`.

jhb added a subscriber: jhb.Mon, Dec 22, 4:21 PM

jhb added inline comments.

usr.sbin/bhyve/bhyve.8
680
711	That said, I would suggest a more active voice here, for this sentence, something like: Only one active connection is allowed at any time. The TCP server will immediately close new connections while an existing connection is active.
1025	This is the formatting consistently used in the NVMe 1.4b specification.
1181	Using this syntax is fine, but I don't think it is ambiguous to use plain `GB` here and elsewhere. Memory sizing is always power-of-2, so memory/RAM sizes and address space sizes (e.g. the 64K window for VGA) are always power-of-2. (This is different from some other places like disk sizes where it is indeed ambiguous.) In particular, the syntax accepted for the command line doesn't accept the `i`, only `GB` or `G` (see expand_number(3)).

Add updates

Addressed issues.

usr.sbin/bhyve/bhyve.8
1181	I didn't change any or the options, put only free form prose.

Harbormaster completed remote builds in B69438: Diff 168522.Mon, Dec 22, 4:46 PM

ziaee accepted this revision.Tue, Dec 23, 4:15 PM

This revision is now accepted and ready to land.Tue, Dec 23, 4:15 PM

Closed by commit rG5819f8b285fc: bhyve.8: Fix consistency and terms in manpage (authored by michaelo). · Explain WhyTue, Dec 23, 7:13 PM

This revision was automatically updated to reflect the committed changes.

michaelo added a commit: rG5819f8b285fc: bhyve.8: Fix consistency and terms in manpage.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

67 lines

Diff 168557

usr.sbin/bhyve/bhyve.8

Loading...