vtnet: improve interface capability handling
ClosedPublic
Actions

Authored by tuexen on Mon, Sep 22, 8:00 PM.

Details

Reviewers

timo.voelker_fh-muenster.de
kp
bryanv
bcr

Group Reviewers

manpages

Commits

rGfed8dbe794a6: vtnet: improve interface capability handling
rGc0598ba49d2c: vtnet: improve interface capability handling
rGeaf619fddcb2: vtnet: improve interface capability handling

Summary

Enable the handling of the IFCAP_RXCSUM_IPV6 handling by handling IFCAP_RXCSUM and IFCAP_RXCSUM_IPV6 as a pair.
Also make clear, that software and hardware LRO require receive checksum offload.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Mon, Sep 22, 8:00 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptMon, Sep 22, 8:00 PM

tuexen requested review of this revision.Mon, Sep 22, 8:00 PM

tuexen added a reviewer: manpages.

timo.voelker_fh-muenster.de added inline comments.Thu, Sep 25, 3:38 PM

sys/dev/virtio/network/if_vtnet.c
1373	IPv6 has no checksum. How about this * VirtIO does not distinguish between IPv4 and IPv6, * it uses only the one feature flag VIRTIO_NET_F_GUEST_CSUM, * so treat them as a pair.

Improve comments.

tuexen marked an inline comment as done.Thu, Sep 25, 6:34 PM

tuexen added inline comments.

sys/dev/virtio/network/if_vtnet.c
1373	I think the comment is now clearer.

Removing the ifdefs and allow receive checksum offloading for IPv6 is a good thing. Also, enabling/disabling receive checksum pairwise for IPv4 and IPv6 make sense for VirtIO.

This revision is now accepted and ready to land.Fri, Sep 26, 7:15 AM