Page MenuHomeFreeBSD

pmap: Degrade pmap_page_set_attr*() into a no-op on same attribute
ClosedPublic

Authored by olce on Jul 11 2025, 7:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 3, 3:15 AM
Unknown Object (File)
Sun, Mar 29, 12:56 AM
Unknown Object (File)
Sat, Mar 28, 3:43 AM
Unknown Object (File)
Fri, Mar 27, 12:25 PM
Unknown Object (File)
Fri, Mar 27, 3:11 AM
Unknown Object (File)
Thu, Mar 26, 10:23 PM
Unknown Object (File)
Thu, Mar 26, 3:56 PM
Unknown Object (File)
Tue, Mar 24, 12:25 AM

Details

Summary

For 32-bit arm, move the no-op test that was already in place at start
of the function so that it stays first even if the '#if 0' block around
the call to sf_buf_invalidate_cache() is uncommented at some point (if
ever).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65346
Build 62229: arc lint + arc unit

Event Timeline

olce requested review of this revision.Jul 11 2025, 7:27 AM

As a non-expert on the code, LGTM (assuming there aren't some special rules about read-write accesses to the saved attributes).

sys/powerpc/aim/mmu_radix.c
5942

Trivial nit: other files got an extra empty line after the if-return.

This revision is now accepted and ready to land.Jul 12 2025, 6:03 PM