Paths

Table of Contentst

uart: uart_getenv: check for NULL class last, not first
ClosedPublic
Actions

Authored by imp on Fri, Oct 11, 9:54 PM.

Details

Reviewers

markj
andrew
adrian
jhb
jrtc27
bz
marius
oh
manu
kevans
cperciva
mhorne
mw
mmel

Commits

rGc87b3f0006be: uart: uart_getenv: check for NULL class last, not first

Summary

This allows one to specify dt:XXXX when the default class isn't compiled
into the kernel. It's not an error to not have a class until we're done
parsing the spec, so defer checking until then.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59962
Build 56847: arc lint + arc unit

Event Timeline

imp requested review of this revision.Fri, Oct 11, 9:54 PM

imp created this revision.

Harbormaster completed remote builds in B59925: Diff 144682.Fri, Oct 11, 9:54 PM

imp added a parent revision: D47077: uart/pl011: Add support for computing rclk.Fri, Oct 11, 9:54 PM

imp added a child revision: D47079: acpidump: Move to acpi.rsdp.

markj added inline comments.Sat, Oct 12, 2:54 PM

sys/dev/uart/uart_subr.c
293	This is missing a `freeenv(cp)` in the cleanup path.

Check a little later for NULL class... Doesn't really matter and this fixes the leak markj noticed.

Harbormaster completed remote builds in B59962: Diff 144790.Sun, Oct 13, 10:23 PM

adrian accepted this revision.Sun, Oct 13, 10:46 PM

adrian added inline comments.

sys/dev/uart/uart_subr.c
293	is it? inval: has freeenv(cp); in it.

This revision is now accepted and ready to land.Sun, Oct 13, 10:46 PM

markj accepted this revision.Sun, Oct 13, 11:03 PM

markj added inline comments.

sys/dev/uart/uart_subr.c
293	My comment applied to an older version of the diff. Its location is misleading now, which is a bug/quirk of phabricator.

andrew accepted this revision.Mon, Oct 14, 11:56 AM

andrew added inline comments.

sys/dev/uart/uart_subr.c
297–298	We should update this comment while here. Most uart classes are static. Only a few are weak, e.g. the default.

Update the comment too, per Andrew

This revision now requires review to proceed.Mon, Oct 14, 9:11 PM

Harbormaster completed remote builds in B59988: Diff 144852.Mon, Oct 14, 9:11 PM

imp marked 4 inline comments as done.Mon, Oct 14, 9:12 PM

imp added inline comments.

sys/dev/uart/uart_subr.c
297–298	Good idea. Tweaked it a bit.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Oct 14, 10:18 PM

Closed by commit rGc87b3f0006be: uart: uart_getenv: check for NULL class last, not first (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp marked an inline comment as done.

imp added a commit: rGc87b3f0006be: uart: uart_getenv: check for NULL class last, not first.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_subr.c

14 lines

Diff 144790

View Options

uart: uart_getenv: check for NULL class last, not firstClosedPublicActions