newsyslog(8): Disable compression by default.
ClosedPublic
Actions

Authored by delphij on Dec 23 2023, 7:00 AM.

Details

Reviewers

zlei
dvl
debdrup
emaste
imp
markj
otis
zarychtam_plan-b.pwste.edu.pl

Commits

rG83507f9e6fed: newsyslog(8): Disable compression by default in newsyslog.conf.

Summary

Historically, newsyslog compressed rotated log files to save disk space. This was
useful in the early days. However, with modern file systems like ZFS offering native
compression, and with the availability of larger hard drives, the benefits of
additional compression have become less significant. This is particularly true
considering the inconvenience of decompressing log files when searching for
specific patterns.

To reinstate the historical behavior, modify the newsyslog entry in /etc/crontab
to include "-c legacy".

MFC: never

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij requested review of this revision.Dec 23 2023, 7:00 AM

delphij created this revision.

Harbormaster completed remote builds in B55096: Diff 131745.Dec 23 2023, 7:00 AM

lwhsu added a subscriber: lwhsu.Dec 23 2023, 7:18 AM

Looks good to me.

This revision is now accepted and ready to land.Dec 23 2023, 1:11 PM

Ship it.

I like this solution better than my proposed changes to newsyslog.conf

MFC: never

Oh sad, do I need to wait to a future 15-STABLE branch to get this awesome improvement? :-(
Do you think its a real blocker to MFC to STABLE 14 and be included in 14.1-RELEASE?

In D43169#983939, @driesm wrote:

MFC: never

Oh sad, do I need to wait to a future 15-STABLE branch to get this awesome improvement? :-(
Do you think its a real blocker to MFC to STABLE 14 and be included in 14.1-RELEASE?

the commit says 1 week:

https://cgit.freebsd.org/src/commit/?id=906748d208d356a59538dc009a8ad5db040968d9

In D43169#983940, @dvl wrote:

In D43169#983939, @driesm wrote:

MFC: never

Oh sad, do I need to wait to a future 15-STABLE branch to get this awesome improvement? :-(
Do you think its a real blocker to MFC to STABLE 14 and be included in 14.1-RELEASE?

the commit says 1 week:

https://cgit.freebsd.org/src/commit/?d=906748d208d356a59538dc009a8ad5db040968d9

Ah thats good :) then I can change the default my self to none ;).

delphij added a parent revision: D43174: newsyslog(8): Add support of specifying compression method in configuration file..Dec 25 2023, 7:59 AM

Rebase over D43174.

This revision now requires review to proceed.Dec 25 2023, 7:59 AM

Harbormaster completed remote builds in B55104: Diff 131802.Dec 25 2023, 7:59 AM

Limit diff scope to HEAD^..HEAD

Harbormaster completed remote builds in B55105: Diff 131803.Dec 25 2023, 8:00 AM

Is this now dead?

Herald added a subscriber: ziaee. · View Herald TranscriptApr 21 2025, 11:48 AM

dvl added a comment.Apr 21 2025, 11:48 AM

This comment was removed by dvl.

I think it's kind of odd to do both the code change and the config file change. I would be inclined to drop the code change and just commit the change to newsyslog.conf? Or maybe have the installer write out a /etc/newsyslog.conf.d/nocompress file when installing to ZFS? The file would just contain <compress> none with a comment?

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2025, 7:50 AM

Closed by commit rG83507f9e6fed: newsyslog(8): Disable compression by default in newsyslog.conf. (authored by delphij). · Explain Why

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rG83507f9e6fed: newsyslog(8): Disable compression by default in newsyslog.conf..

delphij added a reverting change: rG991ed10e3960: Revert "newsyslog(8): Disable compression by default in newsyslog.conf.".May 8 2025, 3:44 AM