Differential D39434

tcp: reduce argument list to functions that pass a segment
ClosedPublic
Actions

Authored by glebius on Apr 5 2023, 4:36 PM.

Details

Reviewers

rrs

Group Reviewers

transport

Commits

rG35bc0bcc5192: tcp: reduce argument list to functions that pass a segment

Summary

The socket argument is superfluous, as a tcpcb always has one and
only one socket.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50775
Build 47666: arc lint + arc unit

Event Timeline

glebius created this revision.Apr 5 2023, 4:36 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptApr 5 2023, 4:36 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Apr 5 2023, 4:36 PM

Harbormaster completed remote builds in B50775: Diff 119907.Apr 5 2023, 4:36 PM

glebius added a parent revision: D39433: tcp: retire tfb_tcp_hpts_do_segment().Apr 5 2023, 4:36 PM

glebius added a child revision: D39435: tcp: pass tcpcb in the tfb_tcp_ctloutput() method instead of inpcb.

rrs accepted this revision.Apr 7 2023, 7:03 PM

This revision is now accepted and ready to land.Apr 7 2023, 7:03 PM

35bc0bcc5192c68412de9fbf76201d602dd219ca

glebius added a commit: rG35bc0bcc5192: tcp: reduce argument list to functions that pass a segment.Aug 7 2023, 11:51 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_hpts.c

2 lines

tcp_input.c

11 lines

tcp_lro.c

2 lines

tcp_stacks/

19 lines

26 lines

6 lines

12 lines

17 lines

Diff 119907

View Options

sys/netinet/tcp_hpts.c

View Options

sys/netinet/tcp_input.c

View Options

sys/netinet/tcp_lro.c

View Options

sys/netinet/tcp_stacks/bbr.c

View Options

sys/netinet/tcp_stacks/rack.c

View Options

sys/netinet/tcp_stacks/rack_bbr_common.h

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

View Options

tcp: reduce argument list to functions that pass a segmentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 119907

sys/netinet/tcp_hpts.c

sys/netinet/tcp_input.c

sys/netinet/tcp_lro.c

sys/netinet/tcp_stacks/bbr.c

sys/netinet/tcp_stacks/rack.c

sys/netinet/tcp_stacks/rack_bbr_common.h

sys/netinet/tcp_stacks/rack_bbr_common.c

sys/netinet/tcp_var.h

tcp: reduce argument list to functions that pass a segment
ClosedPublic
Actions

Revision Contents
Changeset List