Properly conditionalize clang 15-only flags

[imp]

Summary

Sponsored by: Netflix

[imp]

ah, we do pull in bsd.sys.mk, so this already exists.

[imp]

Add issue from xlib upstream that xin li sent me back in december when I climbed
this hill for stand.

[mjg]

you missed this bit:

diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/Makefile
index 6391255e512b..178d3a3f7ab7 100644
--- a/sys/modules/zlib/Makefile
+++ b/sys/modules/zlib/Makefile
@@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=${NO_WSTRICT_PROTOTYPES} # crc32.c:586
 CWARNFLAGS.trees.c+=${NO_WSTRICT_PROTOTYPES} # trees.c:232
 CWARNFLAGS.zutil.c+=${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32
 
+CWARNFLAGS+=-Wno-deprecated-non-prototype
+

[emaste]

Note the ${NO_WDEPRECATED_NON_PROTOTYPE}

Edit: Oh, the module makefile -- yes.

[imp]

In D38550#877140, @mjg wrote:

you missed this bit:

diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/Makefile
index 6391255e512b..178d3a3f7ab7 100644
--- a/sys/modules/zlib/Makefile
+++ b/sys/modules/zlib/Makefile
@@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=${NO_WSTRICT_PROTOTYPES} # crc32.c:586
 CWARNFLAGS.trees.c+=${NO_WSTRICT_PROTOTYPES} # trees.c:232
 CWARNFLAGS.zutil.c+=${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32
 
+CWARNFLAGS+=-Wno-deprecated-non-prototype
+

Thanks! I'll followup. I missed this before committing.

[jhb]

sys/conf/kern.pre.mk

283

I'm curious why you replaced ${NO_WSTRICT_PROTOTYPES} above with the literal version here?

[imp]

sys/conf/kern.pre.mk

283

So about that... yea... that's clearly a mistake... I'll fix it.