Page MenuHomeFreeBSD
Differential D38199

IfAPI: Add if_llsoftc member accessors for TOEDEV
ClosedPublic
Actions

Authored by jhibbits on Jan 25 2023, 8:59 PM.
Tags
None
Referenced Files
F167825942: D38199.diff
Mon, Aug 24, 7:42 PM
F167768567: D38199.id.diff
Mon, Aug 24, 9:52 AM
Unknown Object (File)
Sun, Aug 23, 11:16 PM
Unknown Object (File)
Sat, Aug 22, 1:52 PM
Unknown Object (File)
Fri, Aug 21, 3:30 PM
Unknown Object (File)
Fri, Aug 21, 3:11 PM
Unknown Object (File)
Fri, Aug 21, 3:08 PM
Unknown Object (File)
Thu, Aug 20, 12:07 PM
View All Files
Subscribers
ae
imp
melifaro

Details

Reviewers
glebius
Group Reviewers
network
Commits
rGc255d1a401c7: IfAPI: Add if_llsoftc member accessors for TOEDEV
Summary

Keep TOEDEV() macro for backwards compatibility, and add a SETTOEDEV()
macro to complement with the new accessors.

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Jan 25 2023, 8:59 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptJan 25 2023, 8:59 PM
jhibbits requested review of this revision.Jan 25 2023, 8:59 PM
Harbormaster completed remote builds in B49232: Diff 115735.Jan 25 2023, 8:59 PM
glebius added inline comments.Jan 31 2023, 4:43 PM
sys/net/if.c
4830

What is the reason to make it non-void?

jhibbits added inline comments.Jan 31 2023, 4:48 PM
sys/net/if.c
4830

It was for consistency with other setters, but I guess that's not consistent either. I'll just make it void.

glebius accepted this revision.Jan 31 2023, 5:06 PM
This revision is now accepted and ready to land.Jan 31 2023, 5:06 PM
Closed by commit rGc255d1a401c7: IfAPI: Add if_llsoftc member accessors for TOEDEV (authored by jhibbits). · Explain WhyJan 31 2023, 8:04 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rGc255d1a401c7: IfAPI: Add if_llsoftc member accessors for TOEDEV.

Revision Contents
Changeset List

PathSize
sys/
dev/
cxgbe/
tom/
2 lines
net/
12 lines
5 lines
2 lines

Diff 116128

View Options

sys/dev/cxgbe/tom/t4_tom.c

Loading...
View Options

sys/net/if.c

Loading...
View Options

sys/net/if_var.h

Loading...
View Options

sys/net/if_vlan.c

Loading...