Page MenuHomeFreeBSD
Differential D37162

vmm: Pass vcpu instead of vm and vcpuid to APIs used from CPU backends.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 9:49 AM
Unknown Object (File)
Wed, Nov 26, 2:29 AM
Unknown Object (File)
Sun, Nov 23, 1:43 AM
Unknown Object (File)
Thu, Nov 20, 9:44 AM
Unknown Object (File)
Nov 13 2025, 2:49 AM
Unknown Object (File)
Nov 9 2025, 6:04 PM
Unknown Object (File)
Nov 1 2025, 2:57 AM
Unknown Object (File)
Nov 1 2025, 1:29 AM
View All Files
Subscribers
bcran
corvink
imp
rgrimes

Details

Reviewers
markj
corvink
Group Reviewers
bhyve
Commits
rG60ba8879c326: vmm: Pass vcpu instead of vm and vcpuid to APIs used from CPU backends.
rG80cb5d845b8f: vmm: Pass vcpu instead of vm and vcpuid to APIs used from CPU backends.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48034
Build 44921: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 27 2022, 3:04 PM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2022, 3:04 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
jhb requested review of this revision.Oct 27 2022, 3:04 PM
Harbormaster completed remote builds in B48034: Diff 112271.Oct 27 2022, 3:04 PM
jhb added a parent revision: D37161: vmm: Use struct vcpu in the instruction emulation code..Oct 27 2022, 3:04 PM
jhb added a child revision: D37163: vmm: Remove vcpuid from I/O port handlers..
jhb mentioned this in D37152: vmm: Remove the per-vm cookie argument from vmmops taking a vcpu..Nov 3 2022, 10:51 PM
corvink accepted this revision.Nov 11 2022, 11:42 AM
corvink added a subscriber: corvink.
corvink added inline comments.
sys/amd64/vmm/amd/svm.c
2635–2636

Nit: You've changed the return type of svm_get_tsc_offset to void. So, this could be void too.

This revision is now accepted and ready to land.Nov 11 2022, 11:42 AM
jhb added inline comments.Nov 11 2022, 5:07 PM
sys/amd64/vmm/amd/svm.c
2635–2636

This is a vmmop function, so the signature is shared with VT-x. The vmx version of this can return errors.

corvink added inline comments.Nov 14 2022, 6:48 AM
sys/amd64/vmm/amd/svm.c
2635–2636

Oh sry, haven't seen it.

markj accepted this revision as: markj.Nov 14 2022, 4:37 PM
Closed by commit rG80cb5d845b8f: vmm: Pass vcpu instead of vm and vcpuid to APIs used from CPU backends. (authored by jhb). · Explain WhyNov 18 2022, 6:28 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG80cb5d845b8f: vmm: Pass vcpu instead of vm and vcpuid to APIs used from CPU backends..
jhb added a commit: rG60ba8879c326: vmm: Pass vcpu instead of vm and vcpuid to APIs used from CPU backends..Jan 26 2023, 10:12 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
58 lines
vmm/
amd/
3 lines
94 lines
10 lines
12 lines
intel/
3 lines
108 lines
10 lines
14 lines
io/
4 lines
136 lines
2 lines
7 lines
8 lines
4 lines
8 lines

Diff 112271

View Options

sys/amd64/include/vmm.h

Loading...
View Options

sys/amd64/vmm/amd/svm.h

Loading...
View Options

sys/amd64/vmm/amd/svm.c

Loading...
View Options

sys/amd64/vmm/amd/svm_msr.h

Loading...
View Options

sys/amd64/vmm/amd/svm_msr.c

Loading...
View Options

sys/amd64/vmm/intel/vmx.h

Loading...
View Options

sys/amd64/vmm/intel/vmx.c

Loading...
View Options

sys/amd64/vmm/intel/vmx_msr.h

Loading...
View Options

sys/amd64/vmm/intel/vmx_msr.c

Loading...
View Options

sys/amd64/vmm/io/vlapic.c

Loading...
View Options

sys/amd64/vmm/vmm.c

Loading...
View Options

sys/amd64/vmm/vmm_dev.c

Loading...
View Options

sys/amd64/vmm/vmm_lapic.h

Loading...
View Options

sys/amd64/vmm/vmm_lapic.c

Loading...
View Options

sys/amd64/vmm/x86.h

Loading...
View Options

sys/amd64/vmm/x86.c

Loading...