vmm svm: Mark all VMCB state caches dirty on vCPU restore.
ClosedPublic
Actions

Authored by jhb on Nov 3 2022, 11:42 PM.

Details

Reviewers

markj
corvink
manu

Group Reviewers

bhyve

Commits

rG02c219b9c9a8: vmm svm: Mark all VMCB state caches dirty on vCPU restore.
rG19b9dd2e08ed: vmm svm: Mark all VMCB state caches dirty on vCPU restore.

Summary

Mark Johnston noticed that this was missing VMCB_CACHE_LBR. Just set
all the bits as is done in svm_run() rather than trying to clear
individual bits.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 3 2022, 11:42 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 3 2022, 11:42 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Nov 3 2022, 11:42 PM

Harbormaster completed remote builds in B48136: Diff 112576.Nov 3 2022, 11:42 PM

jhb added a child revision: D37150: vmm: Rework snapshotting of CPU-specific per-vCPU data..Nov 3 2022, 11:43 PM

jhb added a parent revision: D37149: vmm vmx: Refactor per-vCPU data..

corvink accepted this revision.Nov 4 2022, 7:13 AM

corvink added a reviewer: manu.

This revision is now accepted and ready to land.Nov 4 2022, 7:13 AM

Thanks.

Closed by commit rG19b9dd2e08ed: vmm svm: Mark all VMCB state caches dirty on vCPU restore. (authored by jhb). · Explain WhyNov 18 2022, 6:27 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG19b9dd2e08ed: vmm svm: Mark all VMCB state caches dirty on vCPU restore..

jhb added a commit: rG02c219b9c9a8: vmm svm: Mark all VMCB state caches dirty on vCPU restore..Jan 26 2023, 10:12 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

amd/

svm.c

13 lines

Diff 113289

View Options

vmm svm: Mark all VMCB state caches dirty on vCPU restore.ClosedPublicActions