Page MenuHomeFreeBSD
Differential D37176

bhyve: Remove vestigial support for setting max vCPUs.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:06 PM.
Tags
None
Referenced Files
F82015946: D37176.id.diff
Wed, Apr 24, 2:07 PM
F82015942: D37176.id123101.diff
Wed, Apr 24, 2:07 PM
F82015776: D37176.id112285.diff
Wed, Apr 24, 2:03 PM
Unknown Object (File)
Sun, Apr 21, 8:17 PM
Unknown Object (File)
Tue, Apr 9, 4:12 PM
Unknown Object (File)
Feb 15 2024, 6:02 AM
Unknown Object (File)
Feb 15 2024, 4:05 AM
Unknown Object (File)
Feb 15 2024, 4:05 AM
View All 32 Files
Subscribers
bcran
evgueni.gavrilov_itglobal.com
imp
rgrimes

Details

Reviewers
markj
corvink
manu
Group Reviewers
bhyve
Commits
rG320ce3c3c56b: bhyve: Remove vestigial support for setting max vCPUs.
rGbb1770105022: bhyve: Remove vestigial support for setting max vCPUs.
Summary

The kernel part of the hypervisor is not going to support per-VM
maxcpu limits. The topology is only used to control the values
returned by CPUID leaves for which max vCPUs is not relevant.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Oct 27 2022, 3:06 PM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2022, 3:06 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
jhb requested review of this revision.Oct 27 2022, 3:06 PM
Harbormaster completed remote builds in B48048: Diff 112285.Oct 27 2022, 3:06 PM
jhb added a parent revision: D37175: vmm: Convert VM_MAXCPU into a loader tunable hw.vmm.maxcpu..Oct 27 2022, 3:06 PM
evgueni.gavrilov_itglobal.com added a subscriber: evgueni.gavrilov_itglobal.com.Oct 28 2022, 6:13 AM
jhb retitled this revision from bhyve: Remove vestigal support for setting max vCPUs. to bhyve: Remove vestigial support for setting max vCPUs..Nov 3 2022, 11:14 PM
corvink accepted this revision.Nov 4 2022, 6:43 AM
This revision is now accepted and ready to land.Nov 4 2022, 6:43 AM
corvink added a reviewer: manu.Nov 4 2022, 7:03 AM
jhb added a parent revision: D37272: vmm: Trim some pointless #ifdef KTR..Nov 4 2022, 9:53 PM
jhb removed a parent revision: D37175: vmm: Convert VM_MAXCPU into a loader tunable hw.vmm.maxcpu..
markj accepted this revision as: markj.Nov 11 2022, 4:07 PM

Should vm_set_topology() be updated to indicate that maxcpus is unimplemented? I can see why you didn't remove the parameter at least.

jhb added a comment.Nov 18 2022, 6:08 PM

I may actually wait on this. It might still be useful to set the size of the maxcpus array by passing the limit in via a new vmm_create operation.

corvink added a comment.Nov 19 2022, 10:00 AM

I don't care. It's unused code, so we can remove it. If you like to add support to vm_create for maxcpus, you can easily revert this change. OTOH, it's fine to keep it as it is.

corvink added a comment.May 9 2023, 8:34 AM

@jhb Merge?

jhb added a comment.May 9 2023, 8:30 PM

I guess it's fine to merge.

Closed by commit rGbb1770105022: bhyve: Remove vestigial support for setting max vCPUs. (authored by jhb, committed by corvink). · Explain WhyJun 12 2023, 2:30 PM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rGbb1770105022: bhyve: Remove vestigial support for setting max vCPUs..
corvink added a commit: rG320ce3c3c56b: bhyve: Remove vestigial support for setting max vCPUs..Aug 17 2023, 1:29 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
7 lines

Diff 123101

View Options

usr.sbin/bhyve/bhyverun.c

Loading...