Differential D37258

vmm svm: Use malloc_aligned() instead of contigmalloc().
AbandonedPublic
Actions

Authored by jhb on Nov 3 2022, 11:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 19, 7:38 PM

	Unknown Object (File)
	Fri, Jun 12, 2:39 PM

	Unknown Object (File)
	Thu, Jun 11, 1:16 PM

	Unknown Object (File)
	May 15 2026, 3:49 PM

	Unknown Object (File)
	Apr 28 2026, 7:07 AM

	Unknown Object (File)
	Apr 27 2026, 1:40 AM

	Unknown Object (File)
	Apr 26 2026, 6:56 AM

	Unknown Object (File)
	Apr 21 2026, 11:37 AM

Subscribers

Details

Reviewers

markj
corvink
manu

Group Reviewers

Summary

The MSR and I/O bitmaps just need to be page-aligned. They do
not have other constraints, so malloc_aligned() is sufficient.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48133
Build 45020: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 3 2022, 11:18 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 3 2022, 11:18 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Nov 3 2022, 11:18 PM

Harbormaster completed remote builds in B48133: Diff 112573.Nov 3 2022, 11:18 PM

jhb added a child revision: D37148: vmm svm: Refactor per-vCPU data..Nov 3 2022, 11:18 PM

jhb added a parent revision: D37146: vmm: Simplify saving of absolute TSC values in snapshots..

jhb removed a parent revision: D37146: vmm: Simplify saving of absolute TSC values in snapshots..

jhb added a parent revision: D37147: vmm: Use vm_get_maxcpus() instead of VM_MAXCPU in various places..

corvink accepted this revision.Nov 4 2022, 6:47 AM

This revision is now accepted and ready to land.Nov 4 2022, 6:47 AM

corvink added a reviewer: manu.Nov 4 2022, 7:03 AM

markj added inline comments.Nov 4 2022, 3:30 PM

sys/amd64/vmm/amd/svm.c
574	I don't quite follow. svm_init() stores the PAs of these bitmaps in the VMCB, and they're both larger than PAGE_SIZE, so don't they need to be physically contiguous?

jhb abandoned this revision.Nov 7 2022, 7:54 PM

jhb added inline comments.

sys/amd64/vmm/amd/svm.c
574	Oof, yes, that's a fail on my part.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

amd/

16 lines

Diff 112573

sys/amd64/vmm/amd/svm.c

Loading...