Page MenuHomeFreeBSD

vmm svm: Use malloc_aligned() instead of contigmalloc().
AbandonedPublic

Authored by jhb on Nov 3 2022, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 3:49 AM
Unknown Object (File)
Mon, Mar 31, 3:27 PM
Unknown Object (File)
Sat, Mar 8, 12:47 AM
Unknown Object (File)
Feb 28 2025, 9:07 AM
Unknown Object (File)
Feb 22 2025, 2:12 PM
Unknown Object (File)
Feb 22 2025, 2:07 PM
Unknown Object (File)
Feb 22 2025, 1:50 PM
Unknown Object (File)
Jan 27 2025, 5:06 PM
Subscribers

Details

Reviewers
markj
corvink
manu
Group Reviewers
bhyve
Summary

The MSR and I/O bitmaps just need to be page-aligned. They do
not have other constraints, so malloc_aligned() is sufficient.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48133
Build 45020: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 3 2022, 11:18 PM
This revision is now accepted and ready to land.Nov 4 2022, 6:47 AM
sys/amd64/vmm/amd/svm.c
574

I don't quite follow. svm_init() stores the PAs of these bitmaps in the VMCB, and they're both larger than PAGE_SIZE, so don't they need to be physically contiguous?

jhb added inline comments.
sys/amd64/vmm/amd/svm.c
574

Oof, yes, that's a fail on my part.