Page MenuHomeFreeBSD

vmm svm: Use malloc_aligned() instead of contigmalloc().
AbandonedPublic

Authored by jhb on Nov 3 2022, 11:18 PM.
Tags
None
Referenced Files
F131980885: D37258.diff
Sun, Oct 12, 4:45 PM
Unknown Object (File)
Sun, Oct 5, 11:12 PM
Unknown Object (File)
Wed, Sep 24, 10:24 PM
Unknown Object (File)
Sun, Sep 21, 10:37 AM
Unknown Object (File)
Sep 9 2025, 7:27 PM
Unknown Object (File)
Sep 2 2025, 8:29 PM
Unknown Object (File)
Aug 31 2025, 4:56 AM
Unknown Object (File)
Aug 27 2025, 7:52 PM
Subscribers

Details

Reviewers
markj
corvink
manu
Group Reviewers
bhyve
Summary

The MSR and I/O bitmaps just need to be page-aligned. They do
not have other constraints, so malloc_aligned() is sufficient.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48133
Build 45020: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 3 2022, 11:18 PM
This revision is now accepted and ready to land.Nov 4 2022, 6:47 AM
sys/amd64/vmm/amd/svm.c
574

I don't quite follow. svm_init() stores the PAs of these bitmaps in the VMCB, and they're both larger than PAGE_SIZE, so don't they need to be physically contiguous?

jhb added inline comments.
sys/amd64/vmm/amd/svm.c
574

Oof, yes, that's a fail on my part.