Page MenuHomeFreeBSD
Differential D37147

vmm: Use vm_get_maxcpus() instead of VM_MAXCPU in various places.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:02 PM.
Tags
None
Referenced Files
F133046739: D37147.id112256.diff
Wed, Oct 22, 10:32 AM
F133029231: D37147.id112256.diff
Wed, Oct 22, 5:44 AM
Unknown Object (File)
Fri, Oct 3, 10:03 PM
Unknown Object (File)
Fri, Oct 3, 8:30 PM
Unknown Object (File)
Fri, Oct 3, 7:23 PM
Unknown Object (File)
Fri, Oct 3, 5:41 PM
Unknown Object (File)
Fri, Sep 26, 6:49 AM
Unknown Object (File)
Sep 2 2025, 11:19 PM
View All Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
markj
corvink
manu
Group Reviewers
bhyve
Commits
rG80cce0a3610b: vmm: Use vm_get_maxcpus() instead of VM_MAXCPU in various places.
rG35abc6c238e9: vmm: Use vm_get_maxcpus() instead of VM_MAXCPU in various places.
Summary

Mostly these are loops that iterate over all possible vCPU IDs for a
specific virtual machine.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Oct 27 2022, 3:02 PM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2022, 3:02 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
jhb requested review of this revision.Oct 27 2022, 3:02 PM
jhb added a parent revision: D37146: vmm: Simplify saving of absolute TSC values in snapshots..
jhb added a child revision: D37148: vmm svm: Refactor per-vCPU data..
Harbormaster completed remote builds in B48019: Diff 112256.Oct 27 2022, 3:03 PM
markj accepted this revision as: markj.Nov 2 2022, 2:21 PM
markj added inline comments.
sys/amd64/vmm/intel/vmx.c
1037

I'd just allocate this dynamically, it doesn't seem too painful to do so?

This revision is now accepted and ready to land.Nov 2 2022, 2:21 PM
jhb added inline comments.Nov 3 2022, 10:36 PM
sys/amd64/vmm/intel/vmx.c
1037

It goes away in later commits in this series.

jhb added a child revision: D37258: vmm svm: Use malloc_aligned() instead of contigmalloc()..Nov 3 2022, 11:19 PM
jhb removed a child revision: D37148: vmm svm: Refactor per-vCPU data..
corvink accepted this revision.Nov 4 2022, 6:01 AM
corvink added a reviewer: manu.Nov 4 2022, 7:02 AM
Closed by commit rG35abc6c238e9: vmm: Use vm_get_maxcpus() instead of VM_MAXCPU in various places. (authored by jhb). · Explain WhyNov 18 2022, 6:26 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG35abc6c238e9: vmm: Use vm_get_maxcpus() instead of VM_MAXCPU in various places..
jhb added a commit: rG80cce0a3610b: vmm: Use vm_get_maxcpus() instead of VM_MAXCPU in various places..Jan 26 2023, 10:11 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
amd/
5 lines
4 lines
intel/
12 lines
io/
6 lines
19 lines

Diff 113286

View Options

sys/amd64/vmm/amd/svm.c

Loading...
View Options

sys/amd64/vmm/amd/vmcb.c

Loading...
View Options

sys/amd64/vmm/intel/vmx.c

Loading...
View Options

sys/amd64/vmm/io/vlapic.c

Loading...
View Options

sys/amd64/vmm/vmm.c

Loading...