Page MenuHomeFreeBSD

bhyve: Remove unused vm and vcpu arguments from vm_copy routines.
ClosedPublic

Authored by jhb on Oct 27 2022, 3:04 PM.
Tags
None
Referenced Files
F132338452: D37158.id113089.diff
Thu, Oct 16, 1:08 AM
Unknown Object (File)
Sun, Oct 12, 7:48 AM
Unknown Object (File)
Tue, Sep 30, 6:33 PM
Unknown Object (File)
Fri, Sep 26, 2:55 PM
Unknown Object (File)
Fri, Sep 19, 12:38 AM
Unknown Object (File)
Thu, Sep 18, 1:25 AM
Unknown Object (File)
Aug 27 2025, 1:15 AM
Unknown Object (File)
Aug 26 2025, 7:54 AM

Details

Summary

The arguments identifying the VM and vCPU are only needed for
vm_copy_setup.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Oct 27 2022, 3:04 PM
corvink added inline comments.
lib/libvmmapi/vmmapi.c
1471

This function is empty and seems to be unused. Have you considered removing it?

lib/libvmmapi/vmmapi.c
1471

So this API is kind of funky as the shared vmm_instruction_emul.c calls it both in the kernel and in userland. The in-kernel version is non-empty.

sys/amd64/vmm/vmm.c
2726

This is the in-kernel version.

corvink added inline comments.
lib/libvmmapi/vmmapi.c
1471

Thanks for clarification.

This revision is now accepted and ready to land.Nov 7 2022, 7:00 AM
markj added inline comments.
lib/libvmmapi/vmmapi.c
1471

Might be worth adding a comment to that effect.

jhb marked an inline comment as done.Nov 11 2022, 5:01 PM

Add comment to empty function

This revision now requires review to proceed.Nov 14 2022, 6:19 PM
This revision is now accepted and ready to land.Nov 15 2022, 6:14 AM