Page MenuHomeFreeBSD
Differential D37158

bhyve: Remove unused vm and vcpu arguments from vm_copy routines.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:04 PM.
Tags
None
Referenced Files
F132338452: D37158.id113089.diff
Thu, Oct 16, 1:08 AM
Unknown Object (File)
Sun, Oct 12, 7:48 AM
Unknown Object (File)
Tue, Sep 30, 6:33 PM
Unknown Object (File)
Fri, Sep 26, 2:55 PM
Unknown Object (File)
Fri, Sep 19, 12:38 AM
Unknown Object (File)
Thu, Sep 18, 1:25 AM
Unknown Object (File)
Aug 27 2025, 1:15 AM
Unknown Object (File)
Aug 26 2025, 7:54 AM
View All Files
Subscribers
bcran
corvink
imp
rgrimes

Details

Reviewers
markj
corvink
Group Reviewers
bhyve
Commits
rGd829b4ef464d: bhyve: Remove unused vm and vcpu arguments from vm_copy routines.
rG2b4fe856f44d: bhyve: Remove unused vm and vcpu arguments from vm_copy routines.
Summary

The arguments identifying the VM and vCPU are only needed for
vm_copy_setup.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Oct 27 2022, 3:04 PM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2022, 3:04 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
jhb requested review of this revision.Oct 27 2022, 3:04 PM
Harbormaster completed remote builds in B48030: Diff 112267.Oct 27 2022, 3:04 PM
jhb added a parent revision: D37157: vmm: Use struct vcpu with the vmm_stat API..Oct 27 2022, 3:04 PM
jhb added a child revision: D37159: vmm: Add _KERNEL guards for io headers shared with userspace..
corvink added a subscriber: corvink.Nov 2 2022, 10:16 AM
corvink added inline comments.
lib/libvmmapi/vmmapi.c
1471

This function is empty and seems to be unused. Have you considered removing it?

jhb added inline comments.Nov 4 2022, 2:44 PM
lib/libvmmapi/vmmapi.c
1471

So this API is kind of funky as the shared vmm_instruction_emul.c calls it both in the kernel and in userland. The in-kernel version is non-empty.

sys/amd64/vmm/vmm.c
2726

This is the in-kernel version.

corvink accepted this revision.Nov 7 2022, 7:00 AM
corvink added inline comments.
lib/libvmmapi/vmmapi.c
1471

Thanks for clarification.

This revision is now accepted and ready to land.Nov 7 2022, 7:00 AM
markj accepted this revision as: markj.Nov 11 2022, 3:57 PM
markj added inline comments.
lib/libvmmapi/vmmapi.c
1471

Might be worth adding a comment to that effect.

jhb marked an inline comment as done.Nov 11 2022, 5:01 PM
jhb updated this revision to Diff 113089.Nov 14 2022, 6:19 PM

Add comment to empty function

This revision now requires review to proceed.Nov 14 2022, 6:19 PM
Harbormaster completed remote builds in B48332: Diff 113089.Nov 14 2022, 6:19 PM
corvink accepted this revision.Nov 15 2022, 6:14 AM
This revision is now accepted and ready to land.Nov 15 2022, 6:14 AM
Closed by commit rG2b4fe856f44d: bhyve: Remove unused vm and vcpu arguments from vm_copy routines. (authored by jhb). · Explain WhyNov 18 2022, 6:27 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG2b4fe856f44d: bhyve: Remove unused vm and vcpu arguments from vm_copy routines..
jhb added a commit: rGd829b4ef464d: bhyve: Remove unused vm and vcpu arguments from vm_copy routines..Jan 26 2023, 10:12 PM

Revision Contents
Changeset List

PathSize
lib/
libvmmapi/
11 lines
14 lines
sys/
amd64/
include/
9 lines
vmm/
11 lines
18 lines
usr.sbin/
bhyve/
4 lines
14 lines

Diff 113300

View Options

lib/libvmmapi/vmmapi.h

Loading...
View Options

lib/libvmmapi/vmmapi.c

Loading...
View Options

sys/amd64/include/vmm.h

Loading...
View Options

sys/amd64/vmm/vmm.c

Loading...
View Options

sys/amd64/vmm/vmm_instruction_emul.c

Loading...
View Options

usr.sbin/bhyve/inout.c

Loading...
View Options

usr.sbin/bhyve/task_switch.c

Loading...