Differential D33575

bhyve nvme: Fix LBA out-of-range calculation
ClosedPublic
Actions

Authored by chuck on Dec 19 2021, 4:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 4:49 PM

	Unknown Object (File)
	Sun, Jan 26, 6:13 PM

	Unknown Object (File)
	Jan 18 2025, 5:55 PM

	Unknown Object (File)
	Jan 18 2025, 7:12 AM

	Unknown Object (File)
	Jan 18 2025, 6:52 AM

	Unknown Object (File)
	Jan 18 2025, 5:04 AM

	Unknown Object (File)
	Jan 18 2025, 4:48 AM

	Unknown Object (File)
	Jan 17 2025, 2:11 PM

View All 58 Files

Subscribers

jason_tubnor.net

Details

Reviewers

grehan
jhb
imp
rpokala
allanjude

Group Reviewers

Commits

rG9d8cd04694d4: bhyve nvme: Fix LBA out-of-range calculation

Summary

The LBA out-of-range calculation was off by 1 because it did not account
for the Starting LBA being zero-based.

Fixes UNH ILO 16.0 Test 2.3, Cases 2, 4, and 5 and Test 2.4, Cases 2, 4,
and 5.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43857
Build 40745: arc lint + arc unit

Event Timeline

chuck created this revision.Dec 19 2021, 4:17 PM

Herald added a reviewer: bhyve. · View Herald TranscriptDec 19 2021, 4:17 PM

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

chuck requested review of this revision.Dec 19 2021, 4:17 PM

Harbormaster completed remote builds in B43488: Diff 100304.Dec 19 2021, 4:17 PM

chuck added a parent revision: D33574: bhyve nvme: Add Select support to Get Features.Dec 19 2021, 4:17 PM

chuck added a child revision: D33576: bhyve nvme: Fix reported VWC value.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:14 PM

imp accepted this revision.Dec 23 2021, 6:01 PM

Fix regression reported in Alma Linux + Windows

This revision now requires review to proceed.Jan 11 2022, 5:42 PM

Harbormaster completed remote builds in B43857: Diff 101305.Jan 11 2022, 5:43 PM

jason_tubnor.net added a subscriber: jason_tubnor.net.Jan 11 2022, 10:19 PM

This patch fixed regression that was discovered during workload testing across various guest operating systems (as pointed out by @chuck above).

Tested and confirmed working on the following guest platforms with 14.0-CURRENT (20211223):

OpenBSD 6.9 - NVMe read/write OK
Windows 10 - NVMe read/write OK
Windows Server 2022 - NVMe read/write OK
Alma Linux 8.5 - NVMe read/write OK
FreeBSD 13.0 - NVMe read/write OK

Reviewed by: allanjude

This revision is now accepted and ready to land.Jan 20 2022, 5:12 PM

jhb accepted this revision.Jan 20 2022, 7:32 PM

Closed by commit rG9d8cd04694d4: bhyve nvme: Fix LBA out-of-range calculation (authored by chuck). · Explain WhyJan 29 2022, 11:18 PM

This revision was automatically updated to reflect the committed changes.

chuck added a commit: rG9d8cd04694d4: bhyve nvme: Fix LBA out-of-range calculation.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

13 lines

Diff 101305

usr.sbin/bhyve/pci_nvme.c

Loading...