bhyve nvme: Fix Set Features, AEN
ClosedPublic
Actions

Authored by chuck on Dec 19 2021, 4:17 PM.

Details

Reviewers

grehan
jhb
imp
rpokala

Group Reviewers

bhyve

Commits

rGfa263c532bee: bhyve nvme: Fix Set Features, AEN

Summary

NVMe Controllers which do not support Endurance Groups must return an
error when the Endurance Group Event Aggregate Log Change Notices bit is
set in Set Features, Asynchronous Event Configuration.

Fixes UNH IOL Test 3.12, Case 8

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chuck created this revision.Dec 19 2021, 4:17 PM

Herald added a reviewer: bhyve. · View Herald TranscriptDec 19 2021, 4:17 PM

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

chuck requested review of this revision.Dec 19 2021, 4:17 PM

Harbormaster completed remote builds in B43490: Diff 100306.Dec 19 2021, 4:17 PM

chuck added a parent revision: D33576: bhyve nvme: Fix reported VWC value.Dec 19 2021, 4:18 PM

chuck added a child revision: D33578: bhyve nvme: Fix Identify Namespace, NSID=ffffffff.

allanjude added a subscriber: allanjude.Dec 23 2021, 5:22 PM

allanjude added inline comments.

usr.sbin/bhyve/pci_nvme.c
726	Should we replace this "magic number" with a #define ?

Removed magic number

chuck marked an inline comment as done.Jan 29 2022, 9:00 PM

Harbormaster completed remote builds in B44162: Diff 102086.Jan 29 2022, 9:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2022, 11:18 PM

Closed by commit rGfa263c532bee: bhyve nvme: Fix Set Features, AEN (authored by chuck). · Explain Why

This revision was automatically updated to reflect the committed changes.

chuck added a commit: rGfa263c532bee: bhyve nvme: Fix Set Features, AEN.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_nvme.c

26 lines

Diff 102100

View Options

bhyve nvme: Fix Set Features, AENClosedPublicActions