Tags

None

Referenced Files

	F156453747: D33569.id102092.diff
	Wed, May 13, 7:18 PM

	F156453335: D33569.id100298.diff
	Wed, May 13, 7:13 PM

	F156453306: D33569.id100298.diff
	Wed, May 13, 7:12 PM

	F156453092: D33569.diff
	Wed, May 13, 7:09 PM

	Unknown Object (File)
	Wed, Apr 29, 12:25 PM

	Unknown Object (File)
	Wed, Apr 29, 12:15 PM

	Unknown Object (File)
	Tue, Apr 21, 1:38 PM

	Unknown Object (File)
	Tue, Apr 21, 1:30 PM

Subscribers

Details

Reviewers

grehan
jhb
imp
rpokala
allanjude

Group Reviewers

bhyve

Commits

rG785b5da318bf: bhyve nvme: Add missing Admin opcodes

Summary

Don't treat unsupported Admin commands as Invalid Opcode. Instead return
the proper Invalid Field in Command.

Fixes UNH IOL test 1.17.2

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chuck created this revision.Dec 19 2021, 4:16 PM

Herald added a reviewer: bhyve. · View Herald TranscriptDec 19 2021, 4:16 PM

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

chuck requested review of this revision.Dec 19 2021, 4:16 PM

Harbormaster completed remote builds in B43482: Diff 100298.Dec 19 2021, 4:16 PM

chuck added a parent revision: D33568: bhyve nvme: Implement Log Page Offset.Dec 19 2021, 4:16 PM

chuck added a child revision: D33570: bhyve nvme: Remove redundant AER Limit checks.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:16 PM

imp accepted this revision.Dec 23 2021, 7:24 PM

Closed by commit rG785b5da318bf: bhyve nvme: Add missing Admin opcodes (authored by chuck). · Explain WhyJan 29 2022, 11:17 PM

This revision was automatically updated to reflect the committed changes.

chuck added a commit: rG785b5da318bf: bhyve nvme: Add missing Admin opcodes.

bhyve nvme: Add missing Admin opcodes
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 102092

usr.sbin/bhyve/pci_nvme.c

bhyve nvme: Add missing Admin opcodesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 102092

usr.sbin/bhyve/pci_nvme.c

bhyve nvme: Add missing Admin opcodes
ClosedPublic
Actions

Revision Contents
Changeset List