Page MenuHomeFreeBSD

bhyve nvme: Implement LBA Range Type feature
AbandonedPublic

Authored by chuck on Dec 19 2021, 4:16 PM.
Tags
None
Referenced Files
F156836315: D33567.diff
Sat, May 16, 7:40 PM
Unknown Object (File)
Wed, May 13, 7:16 PM
Unknown Object (File)
Wed, May 13, 7:09 PM
Unknown Object (File)
Wed, May 6, 10:38 PM
Unknown Object (File)
Sat, May 2, 11:54 PM
Unknown Object (File)
Fri, May 1, 12:03 PM
Unknown Object (File)
Sat, Apr 25, 8:34 AM
Unknown Object (File)
Apr 15 2026, 12:22 PM

Details

Reviewers
grehan
jhb
imp
rpokala
allanjude
Group Reviewers
bhyve
Summary

Add minimal support for setting and getting the LBA Range Type feature.

Tested by:
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43480
Build 40368: arc lint + arc unit

Event Timeline

chuck requested review of this revision.Dec 19 2021, 4:16 PM

struct nvme_lba_range_type lba_range did not initialize when the controller initialized/reset.
how about add an init method to the nvme_feature_obj struct and call it when the feature needs initialization.

allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:21 PM
imp added inline comments.
usr.sbin/bhyve/pci_nvme.c
336

Does this need to be initialized to something other than 0? Do we need to persist set values?

Dropping this feature as it is not mandatory