Page MenuHomeFreeBSD

bhyve nvme: Implement LBA Range Type feature
AbandonedPublic

Authored by chuck on Dec 19 2021, 4:16 PM.
Tags
None
Referenced Files
F81693473: D33567.diff
Sat, Apr 20, 1:19 AM
Unknown Object (File)
Mon, Apr 8, 4:37 PM
Unknown Object (File)
Mon, Apr 8, 3:52 PM
Unknown Object (File)
Mon, Apr 8, 3:36 PM
Unknown Object (File)
Mon, Apr 8, 3:09 PM
Unknown Object (File)
Jan 30 2024, 11:50 PM
Unknown Object (File)
Dec 20 2023, 6:51 AM
Unknown Object (File)
Nov 28 2023, 5:16 PM

Details

Reviewers
grehan
jhb
imp
rpokala
allanjude
Group Reviewers
bhyve
Summary

Add minimal support for setting and getting the LBA Range Type feature.

Tested by:
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43480
Build 40368: arc lint + arc unit

Event Timeline

chuck requested review of this revision.Dec 19 2021, 4:16 PM

struct nvme_lba_range_type lba_range did not initialize when the controller initialized/reset.
how about add an init method to the nvme_feature_obj struct and call it when the feature needs initialization.

allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:21 PM
imp added inline comments.
usr.sbin/bhyve/pci_nvme.c
336

Does this need to be initialized to something other than 0? Do we need to persist set values?

Dropping this feature as it is not mandatory