Page MenuHomeFreeBSD

bhyve nvme: Remove redundant AER Limit checks
ClosedPublic

Authored by chuck on Dec 19 2021, 4:17 PM.
Tags
None
Referenced Files
F135594940: D33570.id100299.diff
Tue, Nov 11, 3:45 AM
Unknown Object (File)
Wed, Nov 5, 5:49 AM
Unknown Object (File)
Wed, Nov 5, 3:19 AM
Unknown Object (File)
Thu, Oct 30, 5:32 AM
Unknown Object (File)
Thu, Oct 23, 6:47 PM
Unknown Object (File)
Wed, Oct 22, 2:38 AM
Unknown Object (File)
Sun, Oct 19, 12:14 AM
Unknown Object (File)
Tue, Oct 14, 4:29 AM

Details

Summary

The NVMe emulation checked if the Asynchronous Event Request Limit
(a.k.a AERL) would be exceeded in pci_nvme_aer_add(), but this function
is only called from nvme_opc_async_event_req() which also checks for
exceeding the AERL.

While in the neighborhood, fix / enhance the debug logging.

Tested by:
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck requested review of this revision.Dec 19 2021, 4:17 PM
allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:16 PM

I don't see the 'while in the area' changes, so omit that from the final commit message.

In D33570#759866, @imp wrote:

I don't see the 'while in the area' changes, so omit that from the final commit message.

Good catch. Fixed.

This revision was automatically updated to reflect the committed changes.