Page MenuHomeFreeBSD

bhyve nvme: Remove redundant AER Limit checks
ClosedPublic

Authored by chuck on Dec 19 2021, 4:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 19, 12:14 AM
Unknown Object (File)
Tue, Oct 14, 4:29 AM
Unknown Object (File)
Sun, Oct 12, 2:18 AM
Unknown Object (File)
Fri, Sep 26, 2:34 AM
Unknown Object (File)
Wed, Sep 24, 10:48 AM
Unknown Object (File)
Sep 21 2025, 12:09 PM
Unknown Object (File)
Aug 24 2025, 10:05 AM
Unknown Object (File)
Aug 14 2025, 10:16 PM

Details

Summary

The NVMe emulation checked if the Asynchronous Event Request Limit
(a.k.a AERL) would be exceeded in pci_nvme_aer_add(), but this function
is only called from nvme_opc_async_event_req() which also checks for
exceeding the AERL.

While in the neighborhood, fix / enhance the debug logging.

Tested by:
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck requested review of this revision.Dec 19 2021, 4:17 PM
allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:16 PM

I don't see the 'while in the area' changes, so omit that from the final commit message.

In D33570#759866, @imp wrote:

I don't see the 'while in the area' changes, so omit that from the final commit message.

Good catch. Fixed.

This revision was automatically updated to reflect the committed changes.