Page MenuHomeFreeBSD

bhyve nvme: Fix Identify Namespace, NSID=ffffffff
ClosedPublic

Authored by chuck on Dec 19 2021, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 9:49 AM
Unknown Object (File)
Thu, Oct 9, 8:34 AM
Unknown Object (File)
Sun, Sep 28, 1:22 PM
Unknown Object (File)
Thu, Sep 25, 11:34 PM
Unknown Object (File)
Sep 18 2025, 11:53 PM
Unknown Object (File)
Sep 12 2025, 3:36 AM
Unknown Object (File)
Sep 4 2025, 6:35 PM
Unknown Object (File)
Aug 15 2025, 6:43 AM

Details

Summary

If the NVMe Controller doesn't support Namespace Management, it should
return "Invalid Namespace or Format" when the Host request Identify
Namespace with the global NSID value.

Fixes UNH IOL 16.0 Test 9.1, Case 6

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck requested review of this revision.Dec 19 2021, 4:18 PM
allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:20 PM

This one surprises me, but I'll defer to the UNH tests

In D33578#759871, @imp wrote:

This one surprises me, but I'll defer to the UNH tests

The UNH tests do get things wrong on occasion, but the 1.4c specification in section 5.15.2.1 states:

5.15.2.1 Identify Namespace data structure (CNS 00h)
...
capabilities that are common across namespaces for the controller. If the controller does not support the
Namespace Management capability and the NSID field is set to FFFFFFFFh, then the controller shall abort
the command with a status code of Invalid Namespace or Format.

So I think the test is correct here.