Page MenuHomeFreeBSD
Differential D33577

bhyve nvme: Fix Set Features, AEN
ClosedPublic
Actions

Authored by chuck on Dec 19 2021, 4:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 6, 1:10 PM
Unknown Object (File)
Thu, Oct 1, 3:31 AM
Unknown Object (File)
Tue, Sep 29, 6:17 PM
Unknown Object (File)
Tue, Sep 29, 6:17 PM
Unknown Object (File)
Mon, Sep 28, 7:01 PM
Unknown Object (File)
Mon, Sep 28, 7:01 PM
Unknown Object (File)
Mon, Sep 28, 5:33 PM
Unknown Object (File)
Tue, Sep 22, 6:28 PM
View All Files
Subscribers
allanjude
bcran
dab
rgrimes

Details

Reviewers
grehan
jhb
imp
rpokala
Group Reviewers
bhyve
Commits
rGfa263c532bee: bhyve nvme: Fix Set Features, AEN
Summary

NVMe Controllers which do not support Endurance Groups must return an
error when the Endurance Group Event Aggregate Log Change Notices bit is
set in Set Features, Asynchronous Event Configuration.

Fixes UNH IOL Test 3.12, Case 8

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44162
Build 41050: arc lint + arc unit

Event Timeline

chuck created this revision.Dec 19 2021, 4:17 PM
Herald added a reviewer: bhyve. · View Herald TranscriptDec 19 2021, 4:17 PM
Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript
chuck requested review of this revision.Dec 19 2021, 4:17 PM
Harbormaster completed remote builds in B43490: Diff 100306.Dec 19 2021, 4:17 PM
chuck added a parent revision: D33576: bhyve nvme: Fix reported VWC value.Dec 19 2021, 4:18 PM
chuck added a child revision: D33578: bhyve nvme: Fix Identify Namespace, NSID=ffffffff.
allanjude added a subscriber: allanjude.Dec 23 2021, 5:22 PM
allanjude added inline comments.
usr.sbin/bhyve/pci_nvme.c
726

Should we replace this "magic number" with a #define ?

chuck updated this revision to Diff 102086.Jan 29 2022, 9:00 PM

Removed magic number

chuck marked an inline comment as done.Jan 29 2022, 9:00 PM
Harbormaster completed remote builds in B44162: Diff 102086.Jan 29 2022, 9:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2022, 11:18 PM
Closed by commit rGfa263c532bee: bhyve nvme: Fix Set Features, AEN (authored by chuck). · Explain Why
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rGfa263c532bee: bhyve nvme: Fix Set Features, AEN.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
26 lines

Diff 102086

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...