Page MenuHomeFreeBSD

ifnet: allocate index at the end of if_alloc_domain()
ClosedPublic

Authored by glebius on Dec 4 2021, 9:13 PM.

Details

Summary

Now that if_alloc_domain() never fails and actually doesn't
expose ifnet to outside we can eliminate IFNET_HOLD and two
step index allocation.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Apart from the suggestion this looks fine.

sys/net/if.c
635

idx here could right away be ifp->ifindex like it is done in if_vmove() further down and then the new "assignment" in ifnet_setbyindex() doesn't have to be there either as it is not related to that function (it is the reverse).

sys/net/if.c
635

That's what next revisions do. Collapse ifindex_alloc, ifnet_setbyindex and if_grow.

This revision is now accepted and ready to land.Dec 6 2021, 10:47 AM