Page MenuHomeFreeBSD

ifnet: make V_if_index static to if.c
ClosedPublic

Authored by glebius on Dec 4 2021, 9:16 PM.

Details

Reviewers
bz
kp
glebius
Group Reviewers
network
Summary

This requires moving net.link.generic sysctl declaration from if_mib.c
to if.c. Ideally if_mib.c needs just to be merged to if.c, but they
have different license texts.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 43143
Build 40031: arc lint + arc unit

Event Timeline

sys/net/if.c
321

I'd rather try keep the separation between it and if_mib. (Also, if.c Is huge and worth splitting by itself).

Speaking of static -
Maybe having a SYSCTL_PROC with an V_ifindex accessor function will do?

One might also consider to simply remove the variable declaration from public space and into the implementation(s) -- possibly along with a comment?

Maybe having a SYSCTL_PROC with an V_ifindex accessor function will do?

No, that won't work.

One might also consider to simply remove the variable declaration from public space and into the implementation(s) -- possibly along with a comment?

So don't make it static, remove declaration from if_var.h put the declaration into if_mib.c itself? Will work, but it will leave tempting possibility for other modules in kernel to put declaration, too. And I want to make it private to if.c.

This revision is now accepted and ready to land.Dec 7 2021, 6:04 AM