Page MenuHomeFreeBSD
Differential D31833

newbus: add bus_topo_assert
ClosedPublic
Actions

Authored by imp on Sep 4 2021, 5:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 4:53 AM
Unknown Object (File)
Thu, Nov 27, 12:04 PM
Unknown Object (File)
Thu, Nov 27, 7:54 AM
Unknown Object (File)
Sun, Nov 23, 9:45 PM
Unknown Object (File)
Wed, Nov 19, 7:06 AM
Unknown Object (File)
Mon, Nov 17, 10:19 PM
Unknown Object (File)
Sat, Nov 15, 4:50 PM
Unknown Object (File)
Sat, Nov 15, 6:31 AM
View All Files
Subscribers
None

Details

Reviewers
mav
jhb
• hselasky
wulf
Commits
rGd14bc7230ba5: newbus: add bus_topo_assert
Summary

Add bus_topo_assert() and implmement it as GIANT_REQUIRED for the
moment. This will allow us to change more easily to a newbus-specific
lock int he future.

Sponsored by: Netflix

Test Plan

Note: I think the giant manipulation in hyperv/vmbus is related to newbus, but there's more to it that I've not read through the code.
I've tried to add reviews for all the maintainers of this code, even though the change is, at this moment, syntactic sugar only.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 4 2021, 5:09 AM
imp created this revision.
Harbormaster completed remote builds in B41367: Diff 94652.Sep 4 2021, 5:09 AM
imp edited the test plan for this revision. (Show Details)Sep 4 2021, 5:12 AM
imp added reviewers: mav, jhb, • hselasky, wulf.
mav accepted this revision.Sep 4 2021, 3:04 PM
This revision is now accepted and ready to land.Sep 4 2021, 3:04 PM
imp updated this revision to Diff 94660.Sep 4 2021, 3:26 PM

Add topo assert in mii_attach

This revision now requires review to proceed.Sep 4 2021, 3:26 PM
Harbormaster completed remote builds in B41373: Diff 94660.Sep 4 2021, 3:26 PM
wulf accepted this revision.Sep 4 2021, 4:28 PM
This revision is now accepted and ready to land.Sep 4 2021, 4:28 PM
mav accepted this revision.Sep 4 2021, 6:22 PM
jhb accepted this revision.Nov 29 2021, 6:18 PM
jhb added a parent revision: D31832: bus: mark sysctls MPSAFE.
jhb added a child revision: D31840: hyperv: scanning locking is using the bus mtx.
Closed by commit rGd14bc7230ba5: newbus: add bus_topo_assert (authored by imp). · Explain WhyDec 10 2021, 12:06 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGd14bc7230ba5: newbus: add bus_topo_assert.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
6 lines
bhnd/
4 lines
3 lines
hid/
4 lines
4 lines
mii/
2 lines
kern/
15 lines
sys/
1 line

Diff 99804

View Options

sys/dev/acpica/acpi.c

Loading...
View Options

sys/dev/bhnd/bhnd.c

Loading...
View Options

sys/dev/bhnd/bhnd_subr.c

Loading...
View Options

sys/dev/hid/hidbus.c

Loading...
View Options

sys/dev/hid/hmt.c

Loading...
View Options

sys/dev/mii/mii.c

Loading...
View Options

sys/kern/subr_bus.c

Loading...
View Options

sys/sys/bus.h

Loading...