Page MenuHomeFreeBSD

hyperv: scanning locking is using the bus mtx
ClosedPublic

Authored by imp on Sep 5 2021, 3:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 6, 1:39 AM
Unknown Object (File)
Sat, Dec 6, 1:35 AM
Unknown Object (File)
Sat, Dec 6, 1:26 AM
Unknown Object (File)
Mon, Nov 24, 4:52 PM
Unknown Object (File)
Sun, Nov 23, 4:06 AM
Unknown Object (File)
Fri, Nov 21, 1:35 PM
Unknown Object (File)
Nov 9 2025, 6:11 AM
Unknown Object (File)
Nov 7 2025, 3:56 AM
Subscribers
None

Details

Summary

The scanning code uses Giant to coordinate its accesses to newbus as
well as to synchronize a little state within hyperv's vmbus. Switch to
the new bus_topo_* functions instead of referring to Giant explicitly.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 5 2021, 3:35 AM
imp created this revision.

Looks good, but while at hyper-v I'd also do it for hv_pci_delete_device().

This revision is now accepted and ready to land.Nov 29 2021, 6:20 PM

Arguably, it is the strangest use of Giant from all code I ever see.

This revision was automatically updated to reflect the committed changes.