Page MenuHomeFreeBSD

hyperv: scanning locking is using the bus mtx
ClosedPublic

Authored by imp on Sep 5 2021, 3:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 11:36 PM
Unknown Object (File)
Feb 9 2024, 6:07 PM
Unknown Object (File)
Feb 5 2024, 10:30 PM
Unknown Object (File)
Jan 8 2024, 11:57 PM
Unknown Object (File)
Jan 5 2024, 10:25 AM
Unknown Object (File)
Jan 5 2024, 10:21 AM
Unknown Object (File)
Jan 5 2024, 10:21 AM
Unknown Object (File)
Jan 5 2024, 10:06 AM
Subscribers
None

Details

Summary

The scanning code uses Giant to coordinate its accesses to newbus as
well as to synchronize a little state within hyperv's vmbus. Switch to
the new bus_topo_* functions instead of referring to Giant explicitly.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 5 2021, 3:35 AM
imp created this revision.

Looks good, but while at hyper-v I'd also do it for hv_pci_delete_device().

This revision is now accepted and ready to land.Nov 29 2021, 6:20 PM

Arguably, it is the strangest use of Giant from all code I ever see.

This revision was automatically updated to reflect the committed changes.