Page MenuHomeFreeBSD

hyperv: scanning locking is using the bus mtx
ClosedPublic

Authored by imp on Sep 5 2021, 3:35 AM.
Tags
None
Referenced Files
F157504140: D31840.id94678.diff
Fri, May 22, 4:14 AM
Unknown Object (File)
Wed, May 20, 4:16 PM
Unknown Object (File)
Wed, May 20, 6:13 AM
Unknown Object (File)
Tue, May 19, 6:46 AM
Unknown Object (File)
Sun, May 17, 8:01 AM
Unknown Object (File)
Wed, May 13, 1:37 AM
Unknown Object (File)
Fri, May 8, 7:19 PM
Unknown Object (File)
Fri, May 1, 9:49 PM
Subscribers
None

Details

Summary

The scanning code uses Giant to coordinate its accesses to newbus as
well as to synchronize a little state within hyperv's vmbus. Switch to
the new bus_topo_* functions instead of referring to Giant explicitly.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 5 2021, 3:35 AM
imp created this revision.

Looks good, but while at hyper-v I'd also do it for hv_pci_delete_device().

This revision is now accepted and ready to land.Nov 29 2021, 6:20 PM

Arguably, it is the strangest use of Giant from all code I ever see.

This revision was automatically updated to reflect the committed changes.