Page MenuHomeFreeBSD

hyperv: scanning locking is using the bus mtx
ClosedPublic

Authored by imp on Sep 5 2021, 3:35 AM.
Tags
None
Referenced Files
F146516184: D31840.diff
Tue, Mar 3, 7:38 AM
F146491055: D31840.diff
Tue, Mar 3, 3:02 AM
Unknown Object (File)
Sat, Feb 28, 3:03 PM
Unknown Object (File)
Fri, Feb 27, 5:24 PM
Unknown Object (File)
Sun, Feb 22, 1:04 AM
Unknown Object (File)
Jan 5 2026, 4:02 AM
Unknown Object (File)
Dec 26 2025, 1:18 PM
Unknown Object (File)
Dec 15 2025, 8:38 AM
Subscribers
None

Details

Summary

The scanning code uses Giant to coordinate its accesses to newbus as
well as to synchronize a little state within hyperv's vmbus. Switch to
the new bus_topo_* functions instead of referring to Giant explicitly.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 5 2021, 3:35 AM
imp created this revision.

Looks good, but while at hyper-v I'd also do it for hv_pci_delete_device().

This revision is now accepted and ready to land.Nov 29 2021, 6:20 PM

Arguably, it is the strangest use of Giant from all code I ever see.

This revision was automatically updated to reflect the committed changes.