Page MenuHomeFreeBSD

hyperv: scanning locking is using the bus mtx
ClosedPublic

Authored by imp on Sep 5 2021, 3:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 27, 1:42 AM
Unknown Object (File)
Sun, Jul 26, 4:04 PM
Unknown Object (File)
Fri, Jul 24, 1:05 PM
Unknown Object (File)
Thu, Jul 23, 2:58 PM
Unknown Object (File)
Thu, Jul 23, 2:58 PM
Unknown Object (File)
Jun 18 2026, 8:16 PM
Unknown Object (File)
Jun 17 2026, 3:35 PM
Unknown Object (File)
May 30 2026, 11:10 PM
Subscribers
None

Details

Summary

The scanning code uses Giant to coordinate its accesses to newbus as
well as to synchronize a little state within hyperv's vmbus. Switch to
the new bus_topo_* functions instead of referring to Giant explicitly.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 5 2021, 3:35 AM
imp created this revision.

Looks good, but while at hyper-v I'd also do it for hv_pci_delete_device().

This revision is now accepted and ready to land.Nov 29 2021, 6:20 PM

Arguably, it is the strangest use of Giant from all code I ever see.

This revision was automatically updated to reflect the committed changes.