Page MenuHomeFreeBSD

hyperv: scanning locking is using the bus mtx
ClosedPublic

Authored by imp on Sep 5 2021, 3:35 AM.
Tags
None
Referenced Files
F152609108: D31840.id94678.diff
Wed, Apr 15, 11:39 PM
Unknown Object (File)
Sun, Apr 12, 3:08 AM
Unknown Object (File)
Sat, Mar 21, 4:11 AM
Unknown Object (File)
Mar 3 2026, 7:38 AM
Unknown Object (File)
Mar 3 2026, 3:02 AM
Unknown Object (File)
Feb 28 2026, 3:03 PM
Unknown Object (File)
Feb 27 2026, 5:24 PM
Unknown Object (File)
Feb 22 2026, 1:04 AM
Subscribers
None

Details

Summary

The scanning code uses Giant to coordinate its accesses to newbus as
well as to synchronize a little state within hyperv's vmbus. Switch to
the new bus_topo_* functions instead of referring to Giant explicitly.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 5 2021, 3:35 AM
imp created this revision.

Looks good, but while at hyper-v I'd also do it for hv_pci_delete_device().

This revision is now accepted and ready to land.Nov 29 2021, 6:20 PM

Arguably, it is the strangest use of Giant from all code I ever see.

This revision was automatically updated to reflect the committed changes.