Page MenuHomeFreeBSD

iflib: emulate counters in netmap mode
ClosedPublic

Authored by franco_opnsense.org on Aug 16 2021, 7:53 AM.

Details

Summary

When iflib devices are in netmap mode the driver
counters are no longer updated making it look from
userspace tools that traffic has stopped.

Submitted by: Stephan de Wit
PR: 252850

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erj added a subscriber: erj.

This seems fine to me.

This revision is now accepted and ready to land.Aug 16 2021, 3:55 PM

Good idea, thanks! I added just a little comment.

sys/net/iflib.c
1081

I think this should be pkt_len, which is the cumulative size of a multi-descriptor packet, whereas len is the size of the last descriptor only.

This revision now requires changes to proceed.Aug 17 2021, 11:22 AM

fixed partial length on tx

franco_opnsense.org added inline comments.
sys/net/iflib.c
1081

Nice catch, thanks! I changed it to pi.ipi_len where pkg_len is stored to avoid the dependency on an internal variable.

This revision is now accepted and ready to land.Aug 17 2021, 11:49 AM

Appreciate the reviews :) Unfortunately I'm not a committer so is someone willing to help out? Thanks in advance.