It wasn't clear from out last conversation if this is ready for review or if there is more related work.

more cleanups, inspired by bz's poking at this whole rssi/nf/signal strength cleanup.

Just dropping a note that this leads to ~10x throughput to pkg.f.o on my laptop -- previously averaging somewhere around ~2-3mbit/s due to constant out-of-order acks, up to ~25-30 mbit/s on average

Are you sure you are not getting full reassembled (re-aggregated) frames on your AX210 that better sees no sequence number checks in net80211 anymore?

Just see https://reviews.freebsd.org/D50929

@bz here's another great example of "almost but not quite what net80211 "expects" " ;-) sigh.. :)

comments from bz

Seems fine ..

I am reluctant to click on Request Changes for this but maybe you can still fix the local bits before committing.

Please update the bits available comment below keymgmt when you land this

Looks good to me

more "correct" fixes, i hope!

In D52523#1211903, @adrian wrote:

ok, I'd like to land this and then follow it up with some more iwx cleanups. Thanks for pointing them out though, I'm not shocked that the original upstream code was messy with key management too. ;-)

ok, I'd like to land this and then follow it up with some more iwx cleanups. Thanks for pointing them out though, I'm not shocked that the original upstream code was messy with key management too. ;-)

update from bz

This seems ok to me, if it doesn't smoke and you can still do vht then its a good step forward