Note - need to go double check what rinfo->rate is doing here versus rval and our rate lookup. freebsd and openbsd's rate code is a bit different.

This one needs checking/testing to just make sure monitor mode (dedicated, attached to STA interface) works fine.

Note - this one will need a bit more looking at because openbsd and freebsd have slightly different behaving rate stuff. I'd like to make sure rinfo->rate is "right" for whatever is being done here.

In D59107#1356069, @adrian wrote:

Locally tested on RTL8821AU . We should test it on a few more just to make sure it's okay.

Tested on RTL8192CU and RTL8188CUS as well. Probe/attach is fine for these two diffs.

Locally tested on RTL8821AU . We should test it on a few more just to make sure it's okay.

same a the previous one; what devices have you tested this with?
It'd be good to know that it doesn't break any of the current rtwn USB devices.
(I'll try it myself locally tonight.)

which devices have you tested this on? You should add that list to the commit message.

ooh crap how'd i forget about this? Let me go and re-test this and then get it landed.

ok, i think this is correct. I'm bounds checking copy in and copy out of the keys / ioctl buffers; i'm handling 0 byte empty keys properly again so ifconfig and such doesn't error out. I've tested it with CCMP, TKIP and WEP (and I'm sure if CCMP works then GCMP will work, but I'll try to validate that soon.)

change to the new key copy API that returns true/false, not key copy length.

fix; 0 size keys returning 0 == false which leads to APIs returning EINVAL

also it would be nice to count/log the drops here...

This currently throws errors in ifconfig if there's no key (as the key length is 0) - which means it'll error out unless four WEP keys are configured.
I'll need to go and handle the "no key configured, return a blank no key" case before this lands.

another bounds check fix