I'll do the commit. Thanks to Greg for writing this and to everyone who helped to review it!

Who is going to do the actual commit? I'm happy to do it if no-one else wants to? Whoever does it has csprng@ green-light.

Last nit can be done pre-commit or I can whack it post-commit; ok from lua perspective.

Is this ready to be committed? I'm happy to do it myself but markm said he was going to commit (prior to the latest round of changes) -- don't want to commit prematurely if you're still waiting for something.

Yep, I've had basically the exact same opinion as @delphij about the copyright. Let's go with Intel.

So seems like it's easier to just do it all in core.lua, which is where lots of config accesses are anyway.

In D20780#766778, @greg_unrelenting.technology wrote:

err, I have not addressed the "isUEFIBoot" thing and the "This file needs a copyright / license at the top" thing…

err, I have not addressed the "isUEFIBoot" thing and the "This file needs a copyright / license at the top" thing…

Thanks! Can you also MFC it to stable/13 after a week?

In D20780#766643, @cperciva wrote:

Is this waiting for anything else before it gets committed?

Is this waiting for anything else before it gets committed?

Oops, didn't meant to block after the amendment.

Testing this on an RPi4 would be nice, but it's not a dealbreaker.

Hi everyone,

i remember there was some concern in the past where there were very bad rss key choices out there. is there a reason for actually pushing for a random rss key?

In D24989#552693, @neel_neelc.org wrote:

I believe Linux just uses random keys:

• https://github.com/torvalds/linux/blob/29d9f30d4ce6c7a38745a54a8cddface10013490/net/ethtool/ioctl.c#L924

Should I sequence the key into "symmetrical RSS" where the first 32 bits == the next 32 bits, and all subsequent 16 bits chunks are equal?. Or is it something else?

In D24989#552576, @avg wrote:

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

I believe Linux just uses random keys:

In D24989#552576, @avg wrote:

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

@cem thanks for the comments.

@kevans thanks for the suggestion, I added csprng to this thread.