Tue, May 31
May 30 2022
I think this is fine as is.
There's no need to check for nfs in the middle of a string, unless there's some use case I'm unaware of...
May 6 2022
I like the idea! However I burned an DVD for a PowerBook G4 and I only see the regular disc icon.
What's your device model? (based on other sources your patch looks correct. Maybe my firmware is too old for this feature)
May 5 2022
May 3 2022
It really needs someone familiar with bootstrapping to review this.
(Except for being the nfs case, it really has nothing to do with nfs.)
May 2 2022
@rmacklem, 'vfs.root.mountroot' is used as a kernel parameter to specify (or override) where is the root filesystem to be mounted and its partition type. It's usually something like "vfs.root.mountroot=ufs:/dev/da0s1a" if you use a local disk, or "vfs.root.mountroot=nfs:192.168.0.1:/tftpboot/root" if using nfs.
use strncmp instead of strstr in order to match only the beginning of the string
Apr 30 2022
Beyond changing strstr() to a check for "nfs:" at the beginning of the
string, as suggested by sjg@, I don't see a problem with this.
Apr 29 2022
Apr 12 2022
Anything new on this?
Mar 15 2022
edit: commented on wrong revision
Mar 14 2022
Mar 7 2022
Mar 3 2022
Suspending this since it requires changes to continue.
The OS revision part is now being discussed in D34429.
Feb 28 2022
Feb 25 2022
You may cherry pick https://github.com/llvm/llvm-project/commit/53fc5d9b9a0110f097c6e9f7aa3bff3621eaf268 to avoid the local changes.
Feb 10 2022
Jan 24 2022
Or maybe not, I can see some ARM configs also have this, along with comment [KEEP THIS!].
sys/powerpc/conf/MPC85XXSPE also includes COMPAT_43. That should also be removed.
Jan 23 2022
Jan 6 2022
Jan 4 2022
Dec 27 2021
add ports package versions and adjust comments
Dec 23 2021
Dec 22 2021
Dec 21 2021
Dec 14 2021
looking better! Thanks for splitting out the style changes.
Just a couple of bits of feedback for comments.
- style change commited with hash 8d1ab5ad8449e6f51f081e261ed6202a0483a595
- removed COMPAT_FREEBSD8 from config files, since it doesn't exist.
Makes sense. In that case, I think this is good