hm, have you done a universe build with these? whats the LDBL_MANT_DIG supposed to indicate? (eg is this ppc64le only or is this any platform wanting to do 128 bit long float?)

lib/msun/src/s_copysignl.c
45	why's this include here?

ah i see, its from what steve kargl replied to the email thread with.

ok, please at least do a universe build; if it's OK then put that in here and i'll click approve.

Remove LDBL_MANT_DIG guard from ld128 - those are only built on ld128
systems anyway.

Harbormaster completed remote builds in B74409: Diff 180980.Tue, Jun 30, 2:14 PM

It's ok, the only failure is arm64 GENERIC-UP kernel failure which is totally unrelated.

In D57850#1328669, @adrian wrote:

hm, have you done a universe build with these? whats the LDBL_MANT_DIG supposed to indicate? (eg is this ppc64le only or is this any platform wanting to do 128 bit long float?)

I tinderbox for the previous revision, only arm64`s GENERIC-UP kernel failed, but it's completely unrelated. LDBL_MANT_DIG is a macro indicating size of long double's mantissa. It's 113 on IEEE long double. Other ld128 systems also set it:

pkubaj@ten64:$~$ grep -r LDBL_MANT_DIG /usr/include/machine/float.h
/usr/include/machine/float.h:#define    LDBL_MANT_DIG   113
pkubaj@ten64:$~$ uname -rps                                         
FreeBSD 15.1-RELEASE aarch64

Meanwhile, amd64, amd64 has 80-bit ldbl, with 64-bit mantissa:

pkubaj@optiplex-3050-micro:$~$ grep LDBL_MANT_DIG /usr/include/x86/float.h                                                                                                                                       
#define LDBL_MANT_DIG	64
pkubaj@optiplex-3050-micro:$~$ uname -rps
FreeBSD 15.1-RC3-p1 amd64

And powerpc64le 15.1-RELEASE, 64-bit ldbl with 53-bit mantissa, same as double:

root@talos-powerpc64le:~ # grep DBL_MANT_DIG /usr/include/machine/float.h
#define DBL_MANT_DIG    53
#define LDBL_MANT_DIG   DBL_MANT_DIG
root@talos-powerpc64le:~ # uname -rps
FreeBSD 15.1-RELEASE powerpc64le

lib/msun/src/s_copysignl.c
45	That's where LDBL_MANT_DIG is defined. The include is only added to lib/msun/src/*.c files, because they are compiled on all architectures and we only add the weak reference on ld128 systems.

Move include float.h to the top section.

Harbormaster completed remote builds in B74425: Diff 181101.Tue, Jun 30, 7:03 PM

adrian accepted this revision.Wed, Jul 1, 12:17 AM

This revision is now accepted and ready to land.Wed, Jul 1, 12:17 AM

Closed by commit rGc9991e01149b: powerpc64le: switch from calling wrappers to weak references (authored by pkubaj). · Explain WhyWed, Jul 1, 8:21 AM

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rGc9991e01149b: powerpc64le: switch from calling wrappers to weak references.

powerpc64le: define missing msun functionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 181155

lib/msun/Makefile

lib/msun/Symbol_f128.map

lib/msun/ld128/b_tgammal.c

lib/msun/ld128/e_powl.c

lib/msun/ld128/s_erfl.c

lib/msun/ld128/s_exp2l.c

lib/msun/ld128/s_expl.c

lib/msun/ld128/s_logl.c

lib/msun/ld128/s_nanl.c

lib/msun/powerpc/Makefile.inc

lib/msun/powerpc/Symbol_f128.map

lib/msun/powerpc/ld128_compat.c

lib/msun/src/e_acoshl.c

lib/msun/src/e_acosl.c

lib/msun/src/e_asinl.c

lib/msun/src/e_atan2l.c

lib/msun/src/e_atanhl.c

lib/msun/src/e_coshl.c

lib/msun/src/e_fmodl.c

lib/msun/src/e_hypotl.c

lib/msun/src/e_lgammal.c

lib/msun/src/e_remainderl.c

lib/msun/src/e_sinhl.c

lib/msun/src/e_sqrtl.c

lib/msun/src/s_asinhl.c

lib/msun/src/s_atanl.c

lib/msun/src/s_cbrtl.c

lib/msun/src/s_ceill.c

lib/msun/src/s_copysignl.c

lib/msun/src/s_cosl.c

lib/msun/src/s_fabsl.c

lib/msun/src/s_fdim.c

lib/msun/src/s_floorl.c

lib/msun/src/s_fmal.c

lib/msun/src/s_fmaxl.c

lib/msun/src/s_fminl.c

lib/msun/src/s_frexpl.c

lib/msun/src/s_ilogbl.c

lib/msun/src/s_llrintl.c

lib/msun/src/s_llroundl.c

lib/msun/src/s_logbl.c

lib/msun/src/s_lrintl.c

lib/msun/src/s_lroundl.c

lib/msun/src/s_modfl.c

lib/msun/src/s_nearbyint.c

lib/msun/src/s_nextafterl.c

lib/msun/src/s_remquol.c

lib/msun/src/s_rintl.c

lib/msun/src/s_roundl.c

lib/msun/src/s_scalbln.c

lib/msun/src/s_scalbnl.c

lib/msun/src/s_sincosl.c

lib/msun/src/s_sinl.c

lib/msun/src/s_tanhl.c

lib/msun/src/s_tanl.c

lib/msun/src/s_truncl.c

powerpc64le: define missing msun functions
ClosedPublic
Actions

Revision Contents
Changeset List