In D45855#1160514, @kenrap_kennethraplee.com wrote:

In D45855#1160497, @hrs wrote:

Could you explain your configuation and behavior change in more detail?

Sure thing. I use the following in my rc.conf which enlarges the virtual terminal fonts from being small after loading a drm-kmod driver during the booting process:

allscreens_flags="-f spleen-16x32"

After doing a src tree build upgrade today this functionality had stopped. By manually removing both set -o noglob and set +o noglob lines, I restored the original functionality.

The problem is that allscreens_flags relies on the pathname expansion in two places:
https://github.com/freebsd/freebsd-src/blob/4deb9760a9d84d5861ee45162ffebe83f13503b8/libexec/rc/rc.d/syscons#L237-L243
https://github.com/freebsd/freebsd-src/blob/4deb9760a9d84d5861ee45162ffebe83f13503b8/libexec/rc/rc.d/syscons#L381-L387

In D45855#1160402, @kenrap_kennethraplee.com wrote:

This change introduced a regression where my allscreens_flags settings gets ignored at boot.

Looks good to me.

@melifaro Could you explain the motivation for excluding manually-added prefixes from ICMPV6CTL_ND6_PRLIST? I could not find the reason in the review comments for the original change. As I wrote in the description, this sysctl is to list all prefixes in kernel. If a use case needs to pick up a subset of prefixes, it should be handled after getting the whole list.

Looks good to me.

Update the diff to use dnvlist_get_number().

Removing the NI_NUMERICHOST flag except for multicast addresses looks good to me.

The change basically looks good to me, but I added some comments.

I did not test the functionality yet, but I will give it a try with IPv4 and IPv6 configurations.

In D37930#861889, @jlduran_gmail.com wrote:

Also failing this test:

% ping -c1 192.0.2.1
PING 192.0.2.1 (192.0.2.1): 56 data bytes
Request timeout for icmp_seq 0
Request timeout for icmp_seq 0

--- 192.0.2.1 ping statistics ---
1 packets transmitted, 0 packets received, 100.0% packet loss

• sbin/ping: Do not show "Request timeout" when -q is specified
• sbin/ping: Fix the timeout message when -c or -l are specified

In D37493#856006, @t_uemura_macome.co.jp wrote:

• Many changes pointed to by hrs.
• Style(9) changes, some pointed to by takawata.

I put my comments inline. Many of them are style-related, but please fix the memory leak of the sc->res and sc->action queue, at least.