Page MenuHomeFreeBSD

netinet6: Remove ndpr_raf_ra_derived flag
Needs ReviewPublic

Authored by hrs on Mon, Aug 26, 5:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 9, 6:52 PM
Unknown Object (File)
Mon, Sep 2, 4:44 PM
Unknown Object (File)
Thu, Aug 29, 1:37 AM
Unknown Object (File)
Thu, Aug 29, 12:54 AM
Unknown Object (File)
Wed, Aug 28, 8:28 AM
Unknown Object (File)
Tue, Aug 27, 9:12 AM
Unknown Object (File)
Mon, Aug 26, 9:56 PM
Unknown Object (File)
Mon, Aug 26, 9:17 PM

Details

Reviewers
melifaro
Summary

This flag was introduced at 8036234c72c9361711e867cc1a0c6a7fe0babd84 to
prevent the SIOCSPFXFLUSH_IN6 ioctl from removing manually-added entries.
However, this flag did not work well with transitions such as that
the same prefix was manually configured before or after receiving RAs.
Adding an alias manually to one using SLAAC is a typical configuration.

This patch removes the flag because a prefix is derived from an RA
always has an entry in the ndpr_advrtrs member in the struct nd_prefix
or in NDPRF_DETACHED state with no router after the node is attached
to another network. Having a separate flag is not a good idea
because it can cause a mismatch between the flag and the actual situation.

This also removes a prefix check in the ICMPV6CTL_ND6_PRLIST sysctl to
exclude manually-added entries. This ioctl is designed to list all entries,
and there is no relationship to SIOCSPFXFLUSH_IN6.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59182
Build 56069: arc lint + arc unit

Event Timeline

hrs requested review of this revision.Mon, Aug 26, 5:47 PM

@melifaro Could you explain the motivation for excluding manually-added prefixes from ICMPV6CTL_ND6_PRLIST? I could not find the reason in the review comments for the original change. As I wrote in the description, this sysctl is to list all prefixes in kernel. If a use case needs to pick up a subset of prefixes, it should be handled after getting the whole list.