Page MenuHomeFreeBSD

aokblast (SHENG-YI HONG)
AoK_Blast

Projects

User does not belong to any projects.

User Details

User Since
Jun 21 2022, 7:17 PM (155 w, 3 d)

Recent Activity

Yesterday

aokblast added a reviewer for D48199: Add ctfdiff: bnovkov.
Fri, Jun 13, 6:38 PM
aokblast added inline comments to D50818: libusb: add option.
Fri, Jun 13, 2:39 PM
aokblast added inline comments to D50818: libusb: add option.
Fri, Jun 13, 2:38 PM
aokblast added inline comments to D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.
Fri, Jun 13, 2:26 PM
aokblast updated the diff for D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.

Fix comments

Fri, Jun 13, 2:25 PM

Thu, Jun 12

aokblast added a comment to D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

@bz Is there still any concern about this patch? @bapt and what is your opinion about this?
If there is no any problem, I will prepare a github link for merging.

Thu, Jun 12, 11:00 PM
aokblast added a comment to D49587: hwpstate: add CPPC support for pstate driver on AMD.

I'd like the opportunity to review this (next week).

Thu, Jun 12, 10:50 PM
aokblast updated the diff for D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.

Fix format

Thu, Jun 12, 10:45 PM
aokblast updated the diff for D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.

Fix comments' problem and add manual

Thu, Jun 12, 10:43 PM
aokblast added inline comments to D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.
Thu, Jun 12, 10:03 PM
aokblast updated the diff for D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

Fix comment's error and rebase to main

Thu, Jun 12, 10:03 PM
aokblast updated the diff for D50740: libusb: fix incorrect member name in bos_descriptor.

Rebase to main and use macro to provide backward compatibility

Thu, Jun 12, 9:51 PM
aokblast added a comment to D50740: libusb: fix incorrect member name in bos_descriptor.

Is it worth to use something like

Thu, Jun 12, 8:35 PM
aokblast updated the diff for D50818: libusb: add option.

Fix indent

Thu, Jun 12, 7:56 PM
aokblast updated the diff for D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.

Fix indent

Thu, Jun 12, 7:53 PM
aokblast updated the diff for D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.

Fix indent

Thu, Jun 12, 7:50 PM
aokblast updated the summary of D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.
Thu, Jun 12, 7:40 PM
aokblast updated subscribers of D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.

@rcyu Could you please help me check the Mandarine locale?

Thu, Jun 12, 7:33 PM
aokblast added a reviewer for D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does: lwhsu.
Thu, Jun 12, 7:02 PM
aokblast updated the summary of D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.
Thu, Jun 12, 7:01 PM
aokblast requested review of D50820: libusb: implement libusb_setlocale to support different locale of error message as upstream does.
Thu, Jun 12, 7:00 PM
aokblast added a comment to D50818: libusb: add option.

The change about DEBUG_LEVEL to LOG_LEVEL is required to allow set_debug and debug callback works. So add that patch as a parent.

Thu, Jun 12, 4:09 PM
aokblast added reviewers for D50818: libusb: add option: USB, bapt.
Thu, Jun 12, 4:08 PM
aokblast requested review of D50818: libusb: add option.
Thu, Jun 12, 4:08 PM
aokblast updated the diff for D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

Rebase to a correct version

Thu, Jun 12, 4:04 PM
aokblast updated the diff for D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.
  • libusb: add option
Thu, Jun 12, 4:03 PM
aokblast updated the diff for D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

Output to stdout

Thu, Jun 12, 3:59 PM
aokblast updated the diff for D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

Fix indent

Thu, Jun 12, 3:33 PM
aokblast updated the diff for D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

Use vsprintf as callback request a string instead of a fmt + va_args

Thu, Jun 12, 3:22 PM
aokblast updated the summary of D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.
Thu, Jun 12, 3:20 PM
aokblast updated the diff for D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

Replace implementation as a function call to prepare support for log callback

Thu, Jun 12, 12:44 PM

Wed, Jun 11

aokblast updated the diff for D49587: hwpstate: add CPPC support for pstate driver on AMD.

move set_autonomous mode into attach

Wed, Jun 11, 11:26 PM
aokblast updated the summary of D49587: hwpstate: add CPPC support for pstate driver on AMD.
Wed, Jun 11, 11:07 PM
aokblast updated the diff for D49587: hwpstate: add CPPC support for pstate driver on AMD.

fix include order

Wed, Jun 11, 11:06 PM
aokblast updated the diff for D49587: hwpstate: add CPPC support for pstate driver on AMD.

Fix comments

Wed, Jun 11, 11:01 PM
aokblast added a comment to D50739: libusb: fix netlink multicast subsystem name.

Please use this patch for merging if there is no problem. Thanks!

Wed, Jun 11, 7:14 PM
aokblast added a comment to D50739: libusb: fix netlink multicast subsystem name.

Then the output shows:

Wed, Jun 11, 5:01 PM

Sat, Jun 7

aokblast added reviewers for D50740: libusb: fix incorrect member name in bos_descriptor: USB, bapt.
Sat, Jun 7, 7:45 PM
aokblast requested review of D50740: libusb: fix incorrect member name in bos_descriptor.
Sat, Jun 7, 7:45 PM
aokblast added a reviewer for D50739: libusb: fix netlink multicast subsystem name: USB.
Sat, Jun 7, 7:17 PM
aokblast added a reviewer for D50739: libusb: fix netlink multicast subsystem name: bapt.
Sat, Jun 7, 7:12 PM
aokblast requested review of D50739: libusb: fix netlink multicast subsystem name.
Sat, Jun 7, 7:12 PM
aokblast updated the diff for D49587: hwpstate: add CPPC support for pstate driver on AMD.

Use balanced mode as the default epp

Sat, Jun 7, 11:08 AM

Fri, Jun 6

aokblast updated the diff for D49587: hwpstate: add CPPC support for pstate driver on AMD.

Add epp to sysctl

Fri, Jun 6, 9:37 PM

Wed, Jun 4

aokblast added a comment to D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

I am fixing https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277653.

Wed, Jun 4, 2:00 PM
aokblast abandoned D50239: fprintd: fix the shared object install path for pam_fprintd.

Close it as the maintainer decide to fix at the src side.

Wed, Jun 4, 1:06 PM
aokblast updated the diff for D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.

Use >= instead of or

Wed, Jun 4, 12:28 PM
aokblast retitled D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL from libusb: replace LOG_LEVEL with DEBUG_LEVEL to libusb: replace DEBUG_LEVEL with LOG_LEVEL.
Wed, Jun 4, 10:02 AM
aokblast requested review of D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.
Wed, Jun 4, 10:01 AM

Wed, May 28

aokblast added a comment to D50498: atkbd: fix first keystroke force reset.

OK. Patch for merging. Thanks! https://github.com/freebsd/freebsd-src/commit/44469149f29d18b61868b1c6d94c6dbad3f71ddd

Wed, May 28, 7:35 PM

Tue, May 27

aokblast added a comment to D50498: atkbd: fix first keystroke force reset.

@wulf Are you still have concern on the read_kbd_data? If not, I plan to create the patch for merging.

Tue, May 27, 3:46 PM

Sat, May 24

aokblast added a comment to D50498: atkbd: fix first keystroke force reset.

Should we cache read_kbd_data() rather than reread it?

Sat, May 24, 2:38 AM
aokblast updated the diff for D50498: atkbd: fix first keystroke force reset.

Be compatible for correct behavior

Sat, May 24, 2:34 AM

Fri, May 23

aokblast updated subscribers of D46992: libusb: implement `libusb_get_parent`.
Fri, May 23, 7:51 PM
aokblast added a comment to D50239: fprintd: fix the shared object install path for pam_fprintd.
In D50239#1152486, @des wrote:
@des wrote:

OpenPAM does not look for a security subdirectory and never has.

@lwhsu wrote:

Understood, but I am wondering why the original version worked, and all other ports install pam_*.so into lib/security/.

Before we proceed, do we have a definitive answer for these two questions?

The first is not a question, it's a statement.

The answer to the second is that even though the module is in the wrong location, it still works if you provide the full path in your PAM policy.

We can either:

  1. fix all ports that install PAM modules to install them in the correct location, but that will break existing configurations unless we leave a symlink in the incorrect location, or
  2. make OpenPAM look in ${LOCALBASE}/lib/security, but that won't help users of existing releases.
Fri, May 23, 7:32 PM
aokblast added a reviewer for D50498: atkbd: fix first keystroke force reset: imp.
Fri, May 23, 7:23 PM
aokblast added reviewers for D50498: atkbd: fix first keystroke force reset: obiwac_gmail.com, wulf.
Fri, May 23, 7:18 PM
aokblast updated the diff for D50498: atkbd: fix first keystroke force reset.

Fix indent

Fri, May 23, 7:11 PM
aokblast added a comment to D50498: atkbd: fix first keystroke force reset.

See: https://github.com/FrameworkComputer/EmbeddedController/blob/fwk-hx20-hx30-4410/common/keyboard_8042.c#L668

Fri, May 23, 7:09 PM
aokblast requested review of D50498: atkbd: fix first keystroke force reset.
Fri, May 23, 7:08 PM
aokblast updated the diff for D49587: hwpstate: add CPPC support for pstate driver on AMD.

Reset to the correct version

Fri, May 23, 7:08 PM
aokblast updated the diff for D49587: hwpstate: add CPPC support for pstate driver on AMD.
  • atkbd: fix first keystroke force reset
Fri, May 23, 7:06 PM

Wed, May 21

aokblast added a comment to D26407: [PREVIEW] support for gpio interrupts on !intrng platforms.

I am currently working on fixing the bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262282.
This bug is because we only have the poll mode on x86_64 platform for iichid bus.
The first step I have tried is to add pic interface for amdgpio: https://github.com/aokblast/freebsd-src/commit/fd0801d25ff1778c179b2f644047f344114612b2.
But as you and me both know, it is unable to compile because of the miss of INTRNG. We are unable to address the problem by overwrite the bus_setup_intr because the iichid device is not a child of gpiobus.

Wed, May 21, 2:01 PM

Tue, May 20

aokblast added a comment to D50239: fprintd: fix the shared object install path for pam_fprintd.

For sombody who want to merge this patch, thanks!
https://github.com/aokblast/freebsd-ports/commit/1f4c377b046f9153cd1942ea11c7473f87437f03

Tue, May 20, 2:58 PM
aokblast updated the diff for D50239: fprintd: fix the shared object install path for pam_fprintd.

Use LN instead of ln

Tue, May 20, 2:56 PM

Thu, May 15

aokblast added a comment to D50130: x11/boomer: fix mitshm compile and add as default.

I have roll it back. It should be ok now.

Thu, May 15, 5:10 PM
aokblast updated the diff for D50130: x11/boomer: fix mitshm compile and add as default.

Roll back

Thu, May 15, 5:10 PM
aokblast added a comment to D50359: libusb: add SUPER_PLUS in speed enum..

For someone who want to merge this patch, Thanks! https://github.com/freebsd/freebsd-src/commit/1738fd3da159650fd9d1cbe11baa1bfcd5fa1cde

Thu, May 15, 5:09 PM
aokblast updated the diff for D50359: libusb: add SUPER_PLUS in speed enum..

Modify date

Thu, May 15, 5:05 PM
aokblast updated the diff for D50239: fprintd: fix the shared object install path for pam_fprintd.

Use symlink instead of copy file

Thu, May 15, 10:42 AM
aokblast added a reviewer for D50359: libusb: add SUPER_PLUS in speed enum.: bapt.
Thu, May 15, 10:34 AM
aokblast requested review of D50359: libusb: add SUPER_PLUS in speed enum..
Thu, May 15, 10:34 AM

May 11 2025

aokblast added a reviewer for D50299: wine-devel: add support for pulseaudio backend: gerald.
May 11 2025, 5:11 PM
aokblast requested review of D50299: wine-devel: add support for pulseaudio backend.
May 11 2025, 5:10 PM
aokblast updated the summary of D50298: wine-devel: add support for usb build.
May 11 2025, 5:07 PM
aokblast updated the summary of D50298: wine-devel: add support for usb build.
May 11 2025, 5:06 PM
aokblast requested review of D50298: wine-devel: add support for usb build.
May 11 2025, 5:05 PM

May 8 2025

aokblast added a comment to D50170: libusb: emit event when deregister event.

For somebody want to merge this patch, thanks:
https://github.com/aokblast/freebsd-src/commit/8548727194b05ff97fb48e6406a6f26f7f54e593

May 8 2025, 5:41 PM
aokblast added a comment to D50239: fprintd: fix the shared object install path for pam_fprintd.

No, see git blame contrib/openpam/lib/libpam/openpam_constants.c of history of openpam_module_path

May 8 2025, 1:17 AM
aokblast added a comment to D50239: fprintd: fix the shared object install path for pam_fprintd.

There is no change. See pam.conf(5).

May 8 2025, 12:46 AM

May 7 2025

aokblast updated subscribers of D50239: fprintd: fix the shared object install path for pam_fprintd.
May 7 2025, 3:54 PM
aokblast added reviewers for D50239: fprintd: fix the shared object install path for pam_fprintd: lwhsu, haraldei_anduin.net, danfe.
May 7 2025, 3:51 PM
aokblast requested review of D50239: fprintd: fix the shared object install path for pam_fprintd.
May 7 2025, 3:49 PM
aokblast updated the summary of D50170: libusb: emit event when deregister event.
May 7 2025, 3:44 PM
aokblast updated the diff for D50170: libusb: emit event when deregister event.

Elaborate on the commit message

May 7 2025, 3:43 PM
aokblast updated the summary of D50170: libusb: emit event when deregister event.
May 7 2025, 1:52 PM

May 5 2025

aokblast added a comment to D50170: libusb: emit event when deregister event.

See https://github.com/libusb/libusb/blob/master/libusb/hotplug.c#L459

May 5 2025, 5:57 PM
aokblast added a reviewer for D50170: libusb: emit event when deregister event: bapt.
May 5 2025, 5:56 PM
aokblast retitled D50170: libusb: emit event when deregister event from libusb: emit event when deregister to libusb: emit event when deregister event.
May 5 2025, 5:55 PM
aokblast updated the diff for D50170: libusb: emit event when deregister event.

Fix commit message

May 5 2025, 5:55 PM
aokblast requested review of D50170: libusb: emit event when deregister event.
May 5 2025, 5:54 PM

May 4 2025

aokblast added inline comments to D50130: x11/boomer: fix mitshm compile and add as default.
May 4 2025, 4:58 AM
aokblast updated the diff for D50130: x11/boomer: fix mitshm compile and add as default.

Refactor commit msg

May 4 2025, 4:58 AM
aokblast added a comment to D50130: x11/boomer: fix mitshm compile and add as default.

The mitshm compile is needed for multiple screen. When copying the whole image, it takes 10 secs to take the screenshot

So that means that delay only occurs in the multi-screen setups? Just wondering if it's possible to reproduce it on a single-screen laptop.

May 4 2025, 4:52 AM

May 3 2025

aokblast added a reviewer for D50130: x11/boomer: fix mitshm compile and add as default: danfe.
May 3 2025, 8:27 AM
aokblast requested review of D50130: x11/boomer: fix mitshm compile and add as default.
May 3 2025, 8:26 AM

Apr 29 2025

aokblast abandoned D50066: rtlbtfw: add v2 header support.

I use rtl8852be. It is a pcie wireless card.

Apr 29 2025, 5:22 PM
aokblast added a comment to D50066: rtlbtfw: add v2 header support.

Let me clarify two things:

Apr 29 2025, 11:23 AM
aokblast updated subscribers of D50066: rtlbtfw: add v2 header support.

@wulf Hello, I see you are the author of writing this userspace program. Could you please tell me how you test it safely?

Apr 29 2025, 8:53 AM
aokblast updated the summary of D50066: rtlbtfw: add v2 header support.
Apr 29 2025, 8:52 AM