Fix comments

@bz Is there still any concern about this patch? @bapt and what is your opinion about this?
If there is no any problem, I will prepare a github link for merging.

In D49587#1160034, @olce wrote:

I'd like the opportunity to review this (next week).

Fix format

Fix comments' problem and add manual

Fix comment's error and rebase to main

Rebase to main and use macro to provide backward compatibility

Is it worth to use something like

Fix indent

Fix indent

Fix indent

@rcyu Could you please help me check the Mandarine locale?

The change about DEBUG_LEVEL to LOG_LEVEL is required to allow set_debug and debug callback works. So add that patch as a parent.

Rebase to a correct version

• libusb: add option

Output to stdout

Fix indent

Use vsprintf as callback request a string instead of a fmt + va_args

Replace implementation as a function call to prepare support for log callback

move set_autonomous mode into attach

fix include order

Fix comments

Please use this patch for merging if there is no problem. Thanks!

Then the output shows:

Use balanced mode as the default epp

Add epp to sysctl

I am fixing https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277653.

Close it as the maintainer decide to fix at the src side.

Use >= instead of or

OK. Patch for merging. Thanks! https://github.com/freebsd/freebsd-src/commit/44469149f29d18b61868b1c6d94c6dbad3f71ddd

@wulf Are you still have concern on the read_kbd_data? If not, I plan to create the patch for merging.

In D50498#1152600, @wulf wrote:

Should we cache read_kbd_data() rather than reread it?

Be compatible for correct behavior

In D50239#1152486, @des wrote:

In D50239#1152212, @danfe wrote:

@des wrote:

OpenPAM does not look for a security subdirectory and never has.

@lwhsu wrote:

Understood, but I am wondering why the original version worked, and all other ports install pam_*.so into lib/security/.

Before we proceed, do we have a definitive answer for these two questions?

The first is not a question, it's a statement.

The answer to the second is that even though the module is in the wrong location, it still works if you provide the full path in your PAM policy.

We can either:

1. fix all ports that install PAM modules to install them in the correct location, but that will break existing configurations unless we leave a symlink in the incorrect location, or
2. make OpenPAM look in ${LOCALBASE}/lib/security, but that won't help users of existing releases.

Fix indent

See: https://github.com/FrameworkComputer/EmbeddedController/blob/fwk-hx20-hx30-4410/common/keyboard_8042.c#L668

Reset to the correct version

• atkbd: fix first keystroke force reset

I am currently working on fixing the bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262282.
This bug is because we only have the poll mode on x86_64 platform for iichid bus.
The first step I have tried is to add pic interface for amdgpio: https://github.com/aokblast/freebsd-src/commit/fd0801d25ff1778c179b2f644047f344114612b2.
But as you and me both know, it is unable to compile because of the miss of INTRNG. We are unable to address the problem by overwrite the bus_setup_intr because the iichid device is not a child of gpiobus.

For sombody who want to merge this patch, thanks!
https://github.com/aokblast/freebsd-ports/commit/1f4c377b046f9153cd1942ea11c7473f87437f03

Use LN instead of ln

I have roll it back. It should be ok now.

Roll back

For someone who want to merge this patch, Thanks! https://github.com/freebsd/freebsd-src/commit/1738fd3da159650fd9d1cbe11baa1bfcd5fa1cde

Modify date

Use symlink instead of copy file

For somebody want to merge this patch, thanks:
https://github.com/aokblast/freebsd-src/commit/8548727194b05ff97fb48e6406a6f26f7f54e593

No, see git blame contrib/openpam/lib/libpam/openpam_constants.c of history of openpam_module_path

There is no change. See pam.conf(5).

Elaborate on the commit message

See https://github.com/libusb/libusb/blob/master/libusb/hotplug.c#L459

Fix commit message

Refactor commit msg

In D50130#1143544, @danfe wrote:

The mitshm compile is needed for multiple screen. When copying the whole image, it takes 10 secs to take the screenshot

So that means that delay only occurs in the multi-screen setups? Just wondering if it's possible to reproduce it on a single-screen laptop.

I use rtl8852be. It is a pcie wireless card.

Let me clarify two things:

@wulf Hello, I see you are the author of writing this userspace program. Could you please tell me how you test it safely?