Fix sysctl

I did some experiment and you are right, the compiler optimize it above O1.
Also, my assumption is wrong since reminder in aarch64 actually convert into udiv + msub, which is not faster than what we previous have.
Thanks!

Cache and free acpi_cppc_ctx immediately since we only use readonly field.
Also, use roundup to prevent duplicate frequency.

Use readonly struct to reduce memory consumption

Use uint64_t instead of platform dependent register_t

Don't implement FFH in generic bus driver since it is not widely used.

In D55477#1270996, @gallatin wrote:

I tried this on 3 EPYC generations at Netflix. The most recent (AMD EPYC 8434P, AMD EPYC 9535) behaved as expected. There was an dev.hwpstate_amd. node for each CPU, and a lot more freqs were exposed (from 3 to roughly a dozen).
On the oldest EPYC we have is EPYC 7502P, where it didn't change anything. We still only have 3 frequencies exposed. On this machine, we see just a single node from dev.hwpstate:
dev.hwpstate_amd.0.freq_settings: 2500/2750 2200/2200 1500/1350
dev.hwpstate_amd.0.%iommu:
dev.hwpstate_amd.0.%parent: cpu0
dev.hwpstate_amd.0.%pnpinfo:
dev.hwpstate_amd.0.%location:
dev.hwpstate_amd.0.%driver: hwpstate_amd
dev.hwpstate_amd.0.%desc: Cool`n'Quiet 2.0
dev.hwpstate_amd.%parent:

That contrasts to the other machines were we see something like this:

dev.hwpstate_amd.0.freq_settings: 400/-1 522/-1 644/-1 766/-1 888/-1 1010/-1 1132/-1 1255/-1 1377/-1 1499/-1 1621/-1 1743/-1 1865/-1 1987/-1 2110/-1 2232/-1 2354/-1 2476/-1 2598/-1 2720/-1 2843/-1 2965/-1 3087/-1
dev.hwpstate_amd.0.desired_performance: 33
dev.hwpstate_amd.0.maximum_performance: 255
dev.hwpstate_amd.0.minimum_performance: 33
dev.hwpstate_amd.0.epp: 0
dev.hwpstate_amd.0.%iommu:
dev.hwpstate_amd.0.%parent: cpu0
dev.hwpstate_amd.0.%pnpinfo:
dev.hwpstate_amd.0.%location:
dev.hwpstate_amd.0.%driver: hwpstate_amd
dev.hwpstate_amd.0.%desc: AMD Collaborative Processor Performance Control (CPPC)

I'm assuming its a BIOS setting to enable hwpstate, but I don't see it anywhere..

Fix GENERIC build

Return EOPNOTSUPP instead of ENOSUPP

Have rebased to main. Thanks!

Rebase to main

Mark FFH resource as 1 byte to prevent resource overlap

Set min max when something bad happens

Don't free when not possible

Abandon since we have 4.0.3 port.

LGTM for me but I think we should merge the intel's one at the same time.

Ok I see it is reused in other patch

LGTM with a comment.

Delete content instead of removing the whole directory

In D54757#1251289, @jrtc27 wrote:

In D54757#1251288, @aokblast wrote:

In D54757#1251272, @jrtc27 wrote:

I don’t understand, other than it sounding like bear is broken

Sorry, the commit message is not clear. I try to explain with more detail. Please tell me if you need anymore information.

When

pwd == $OBJTOP

, and after

run rm -rf "$OBJTOP"

getcwd(3) will return with error since the directory is deleted.

Under this condition:

When shell is executing:

mkdir -p "$OBJTOP"

bear intercepts the libc exec(3) function call and call getcwd in here. As a result, it causes an error.

So... bear makes assumptions that are false and breaks perfectly fine build system code

In D54757#1251272, @jrtc27 wrote:

I don’t understand, other than it sounding like bear is broken

In D54551#1248714, @markj wrote:

Looks ok, but I'd use int in the function signature.

Minor fixes

Remove License message

Move commit back

Move commit back

Seperate differential

Minor fixes

Use x86_msr_op

Simplify dump_sysctl_cb
Add helper functions for single cpu

Thanks! Thought I sucessfully booted up on a AMD64 machine, this patch touches the basic logic of smp so I will think twice before landing it.

In D54466#1244696, @ziaee wrote:

Thanks aokblast!

This belongs in DESCRIPTION section.
The mdoc(7) manual specifies what goes in SYNOPSIS.

Also, each new sentence starts on a new line.

Minor fixes