usb: Add support for SSPlus isochronous companion descriptor
Needs ReviewPublic
Actions

Authored by aokblast on Sep 1 2025, 3:58 PM.

Details

Reviewers

markj
lwhsu

Group Reviewers

USB

Summary

Support for SuperSpeedPlus (SSPlus) isochronous transfers includes a new
descriptor to allow devices to advertise higher burst sizes.
This patch adds parsing for that descriptor. For the xHCI driver,
we primarily need to use the mult field, which is required when configuring
the PORTSC register.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 66741
Build 63624: arc lint + arc unit

Event Timeline

aokblast created this revision.Sep 1 2025, 3:58 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2025, 3:58 PM

aokblast requested review of this revision.Sep 1 2025, 3:58 PM

Harbormaster completed remote builds in B66739: Diff 161327.Sep 1 2025, 3:58 PM

aokblast added reviewers: USB, markj, lwhsu.Sep 1 2025, 3:59 PM

Follow xHCI document

Herald added subscribers: glebius, melifaro, donner. · View Herald TranscriptSep 1 2025, 4:50 PM

Harbormaster completed remote builds in B66741: Diff 161332.Sep 1 2025, 4:50 PM

lwhsu added inline comments.Sep 3 2025, 2:19 PM

sys/dev/usb/controller/xhci.c
2025
2034

markj added inline comments.Sep 9 2025, 11:54 PM

sys/dev/usb/controller/xhci.c
2020
2329	Do we need to widen the max_{packet,frame} size to uint32_t here?
2527	Please pre-compute this value and save it in a local variable.
sys/dev/usb/usb_device.c
92	These lines are too long.
sys/dev/usb/usb_parse.c
260
284	What is "ss comp"?
sys/dev/usb/usb_transfer.c
28	Why is this not `<dev/usb/usb_endian.h>`? It should also be grouped with other dev/usb includes.
440	Better would be to lift this calculation into a local variable or a subroutine. It's not really readable.