Page MenuHomeFreeBSD

isa_common: add all listed devices
ClosedPublic

Authored by aokblast on Wed, Oct 1, 8:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 3:35 PM
Unknown Object (File)
Sat, Oct 11, 3:35 PM
Unknown Object (File)
Sat, Oct 11, 3:35 PM
Unknown Object (File)
Sat, Oct 11, 3:35 PM
Unknown Object (File)
Sat, Oct 11, 7:04 AM
Unknown Object (File)
Wed, Oct 1, 4:52 PM
Unknown Object (File)
Wed, Oct 1, 3:14 PM
Unknown Object (File)
Wed, Oct 1, 2:05 PM
Subscribers

Details

Summary

In some devices, there may be multiple isa bridges available from different
sources. Therefore, we allow multiple lpc devices to be generated so that
pcie bus won't show "none" anymore.
For example, in my AMD based Framework Laptop, there are two such
bridges. One is acpi hinted, another is from pcie.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think nobody cares about isa bus stuff.
Also, no modern hardware attaches to isa bridge actually.
But it is really annoying for me to see "none" in pciconf -lv.

@jhb do you think that it is fine? Since you know much about pcie, and isa is the predecessor of pci(e).

I suspect this is fine. ISA is all the on boatd IO that's ioport mapped that's not part of pci. It most likely is lpc based and the ACPI enumeration of that jardware should hang off this bus, not the acpi bus for the software model. But practically, this is easier and there's not enough difference to mater.

This revision is now accepted and ready to land.Wed, Oct 1, 10:16 AM
In D52815#1206854, @imp wrote:

I suspect this is fine. ISA is all the on boatd IO that's ioport mapped that's not part of pci. It most likely is lpc based and the ACPI enumeration of that jardware should hang off this bus, not the acpi bus for the software model. But practically, this is easier and there's not enough difference to mater.

Thanks! Warner. I also see the PCI-ISA bridge in QEMU and ISA is actually occupied by pci bus in that case.
I have a question, I see the isa_dma stuff. Wouldn't it mean that ISA can also alloc memory resources? Yes, again, nobody uses it anymore.
These are just some curiosities from a guy who saw that ACPI + PCIe have dominated the x86 world when he had the intellect to play with computers.

aokblast edited the summary of this revision. (Show Details)

I think this is fine. Let's add a longer MFC time (say 2 weeks) to ensure there is no regression.

This revision was automatically updated to reflect the committed changes.