In D25954#577171, @krzysztof.galazka_intel.com wrote:

@lwhsu: Could you, please, remove the declaration in line 610 instead? The first occurrence is in a group of other LED functions.

ping?

ping?

I also feel it is a bit controversial, if we set the immutable flag then we probably don't want it get deleted (then why put it under /tmp?)

I committed this with a pkg-plist fix.

I got this in poudriere:

In D25896#573765, @lwhsu wrote:

In D25896#573758, @ngie wrote:

NAK. I need to add Googletest support to kyua. Now that kyua has been forked, this is straightforward.

Is there an ETA of that? I still hope we can have this before that is implemented. I'm fine and happy to remove this after kyua supports googletest.

In D25742#574818, @miguel_gocobachi.dev wrote:

I was thinking that, the latest commit fixed things like _Object like I did for my patches so the phpdaemon can work with PHP 7+ and some other changes, but I wasnt sure if that is a good way of doing the packages on FreeBSD, I could use the latest commit on the Makefile and remove some unnecessary patches I made if so.

In D25742#574814, @miguel_gocobachi.dev wrote:

Last commit was Jun 30 of this year https://github.com/kakserpom/phpdaemon/commit/9362e586d21343de7fb511f6b3cbfc5ae13a4364

In D25742#571172, @miguel_gocobachi.dev wrote:

I think I got all the comments covered.

Add comment in share/mk/googletest.test.mk to note this is a workaround

Update to the version I used for 11.4-RELEASE

In D25896#573758, @ngie wrote:

NAK. I need to add Googletest support to kyua. Now that kyua has been forked, this is straightforward.

Grammar nit.

In D25538#570437, @wulf wrote:

In D25538#570383, @miguel_gocobachi.dev wrote:

@wulf or @lwhsu can you merge this into the ports tree? thanks!

I need a port committer approval to do this.